chore: fix spelling #6401

jsoref · 2024-06-20T22:20:37Z

Description of the feature or fix

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/lvgl/actions/runs/9605104882#summary-26492045362

The action will report that the changes in this PR would make it happy: https://github.com/jsoref/lvgl/actions/runs/9605105200#summary-26492046938

Notes

Update the Documentation if needed.
Add Examples if relevant.
Add Tests if applicable. (Not done)
Run scripts/code-format.py (astyle version v3.4.12 needs to be installed) and follow the Code Conventions.
Mark the Pull request as Draft while you are working on the first version, and mark is as Ready when it's ready for review.
When changes were requested, re-request review to notify the maintainers.
Help us to review this Pull Request! Anyone can approve or request changes.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2024-06-20T22:20:50Z

.devcontainer/__lv_conf.h__

@@ -352,7 +352,7 @@
 #define LV_ATTRIBUTE_FAST_MEM

 /*Export integer constant to binding. This macro is used with constants in the form of LV_<CONST> that
- *should also appear on LVGL binding API such as Micropython.*/
+ *should also appear on LVGL binding API such as MicroPython.*/


jsoref · 2024-06-20T22:21:16Z

.devcontainer/devcontainer.json

@@ -12,7 +12,7 @@
    "vscode": {
      // Add the IDs of extensions you want installed when the container is created.
      "extensions": [
-        //"searking.preview-vscode"
+        //"searKing.preview-vscode"


https://github.com/searKing/preview-vscode

jsoref · 2024-06-20T22:22:25Z

docs/Doxyfile

I haven't tried to carefully exclude files that are from an upstream. I can drop any files that shouldn't be changed...

jsoref · 2024-06-20T22:23:30Z

docs/README_jp.rst

I've mostly avoided touching translations, but I figured fixing a few brands was ok... Happy to drop if the project prefers to let the localizers deal w/ such things.

docs/ROADMAP.rst

jsoref · 2024-06-20T22:34:38Z

src/libs/lodepng/lodepng.h

@@ -1187,7 +1187,7 @@ The following features are supported by the decoder:
 *) encoding of PNGs, from any raw image to 24- or 32-bit color, or the same color type as the raw image
 *) Adam7 interlace and deinterlace for any color type
 *) loading the image from harddisk or decoding it from a buffer from other sources than harddisk
-*) support for alpha channels, including RGBA color modelete,translucent palettes and color keying
+*) support for alpha channels, including RGBA color model,translucent palettes and color keying


jsoref · 2024-06-20T22:36:49Z

src/libs/thorvg/tvgSwRle.cpp

@@ -325,7 +325,7 @@ static void _genSpan(SwRleData* rle, const SwSpan* spans, uint32_t count)
 }


-static void _horizLine(RleWorker& rw, SwCoord x, SwCoord y, SwCoord area, SwCoord acount)
+static void _horizLine(RleWorker& rw, SwCoord x, SwCoord y, SwCoord area, SwCoord aCount)


There appears to be enough camelCasing in this file to justify this change

jsoref · 2024-06-20T22:37:06Z

src/libs/thorvg/tvgSwStroke.cpp

@@ -862,7 +862,7 @@ bool strokeParseOutline(SwStroke* stroke, const SwOutline& outline)
            ++pt;
            ++types;

-            //emit a signel line_to
+            //emit a single line_to


I wasn't sure if this was signal...

jsoref · 2024-06-20T22:38:26Z

src/libs/tjpgd/tjpgd.c

@@ -316,7 +316,7 @@ static int huffext(     /* >=0: decoded data, <0: error code */
            dc--;       /* Decrement number of available bytes */
            if(flg) {       /* In flag sequence? */
                flg = 0;    /* Exit flag sequence */
-                if(*dp != 0) return 0 - (int)JDR_FMT1;  /* Err: unexpected flag is detected (may be collapted data) */
+                if(*dp != 0) return 0 - (int)JDR_FMT1;  /* Err: unexpected flag is detected (may be corrupted data) */


I tried collapsed and discarded that as a possibility...

jsoref · 2024-06-20T22:39:13Z

src/misc/lv_text.c

@@ -180,8 +180,8 @@ static uint32_t lv_text_get_next_word(const char * txt, const lv_font_t * font,
    uint32_t letter = 0;      /*Letter at i*/
    uint32_t letter_next = 0; /*Letter at i_next*/
    int32_t letter_w;
-    int32_t cur_w = 0;  /*Pixel Width of transversed string*/
-    uint32_t word_len = 0;   /*Number of characters in the transversed word*/
+    int32_t cur_w = 0;  /*Pixel Width of traversed string*/


I could be wrong. transverse is a word...

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

liamHowatt · 2024-06-26T19:28:53Z

Are the fixes in thorvg going to be lost the next time we upgrade it?

Edit: thanks very much for this noble contribution!

FASTSHIFT · 2024-06-27T02:22:54Z

Are the fixes in thorvg going to be lost the next time we upgrade it?

@jsoref
Can you also sync this fix with the Thorvg community? So that it can be synced with the next update ;)

jsoref · 2024-06-27T02:47:07Z

Can you provide me with a link?

FASTSHIFT · 2024-06-27T03:33:01Z

Can you provide me with a link?

It's here: https://github.com/thorvg/thorvg.

kisvegabor

Amazing! Thank you very much!

XuNeo · 2024-06-27T11:11:49Z

Could we add your spelling workflow to lvgl?
https://github.com/jsoref/lvgl/actions/workflows/spelling.yml

jsoref · 2024-06-27T11:46:52Z

Certainly. I tend to talk people through the configuration and prefer to do it as a separate PR after spelling fixes merge. (There are some choices to make.)

kisvegabor · 2024-06-28T07:09:56Z

Thank you Josh!

jsoref added 5 commits June 18, 2024 19:19

spelling: accelerate

b04c2ea

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: acount

81cd303

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: actually

6026791

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: alignment

86e2954

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: alliance

6ac8ed8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref marked this pull request as draft June 20, 2024 22:24

jsoref commented Jun 20, 2024

View reviewed changes

jsoref force-pushed the spelling branch from 56e02cf to 4b4e701 Compare June 20, 2024 22:45

jsoref marked this pull request as ready for review June 20, 2024 22:59

jsoref added 21 commits June 20, 2024 19:39

spelling: allocated

bea4bf6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: allocating

db24853

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: allocator

fef2b56

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: analysis

838ffd6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: animation

270acc3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: animations

70afe08

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: another

3b826dd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anymore

a2fd795

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: available

8a4cea3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: begin

132f405

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: benchmark

2b1c6e0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bracket

39a48bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: build

2327213

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: callback

37a8ba8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: called

dca1351

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cannot

284d80f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: case-sensitive

66a4636

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: channel

06ac2a9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: click

e77a3e4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: codepoint

0bbff9d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: command

fd1d5b3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 10 commits June 20, 2024 19:39

spelling: threads

b678fd4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: todo

142a478

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transform

20edbcb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: traversed

e673f4a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: triangle

2e530d0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: true

377fbe2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unknown

8aba387

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unnecessary

e120c8c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsupported

e3c891d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: width

ade2768

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 4b4e701 to ade2768 Compare June 20, 2024 23:43

FASTSHIFT changed the title ~~Spelling~~ chore: fix spelling Jun 21, 2024

FASTSHIFT previously approved these changes Jun 23, 2024

View reviewed changes

C47D approved these changes Jun 23, 2024

View reviewed changes

kisvegabor previously approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'master' into spelling

e0e8f1a

kisvegabor dismissed stale reviews from FASTSHIFT and themself via e0e8f1a June 27, 2024 10:55

kisvegabor approved these changes Jun 27, 2024

View reviewed changes

XuNeo approved these changes Jun 27, 2024

View reviewed changes

kisvegabor merged commit df0d36f into lvgl:master Jun 28, 2024
19 checks passed

jsoref deleted the spelling branch June 28, 2024 12:09

jsoref mentioned this pull request Jun 28, 2024

test(ci): Add check-spelling workflow #6444

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix spelling #6401

chore: fix spelling #6401

jsoref commented Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

jsoref Jun 20, 2024

liamHowatt commented Jun 26, 2024 •

edited

Loading

FASTSHIFT commented Jun 27, 2024

jsoref commented Jun 27, 2024

FASTSHIFT commented Jun 27, 2024

kisvegabor left a comment

XuNeo commented Jun 27, 2024

jsoref commented Jun 27, 2024

kisvegabor commented Jun 28, 2024

chore: fix spelling #6401

chore: fix spelling #6401

Conversation

jsoref commented Jun 20, 2024

Description of the feature or fix

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liamHowatt commented Jun 26, 2024 • edited Loading

FASTSHIFT commented Jun 27, 2024

jsoref commented Jun 27, 2024

FASTSHIFT commented Jun 27, 2024

kisvegabor left a comment

Choose a reason for hiding this comment

XuNeo commented Jun 27, 2024

jsoref commented Jun 27, 2024

kisvegabor commented Jun 28, 2024

liamHowatt commented Jun 26, 2024 •

edited

Loading