fix(docs): fix broken links #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamHowatt
reviewed
May 9, 2024
|
Thanks! (I thought there will be more broken links 😅 ) |
|
@kisvegabor there might be, that's why I opened #6208 |
liamHowatt
approved these changes
May 10, 2024
There was a problem hiding this comment.
Nice. Looks like the link text matches the header name closest to the ref. If you wanted "CODING STYLE" back, you could do :ref:`CODING STYLE <coding-style>` like here.
Looks good the way it is though:
|
I actually prefer matching the title over all caps. On the other hand, the dot at the end of the sentence was removed accidentally, so I've pushed again. |
liamHowatt
approved these changes
May 10, 2024
FASTSHIFT
approved these changes
May 12, 2024
PGNetHun
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing broken links of:
CODING_STYLE.md ->
Openbutton goes to old fileCODING_STYLE goes to
404 Not found