feat(gridnav): single axis movement flags #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisvegabor
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Wonderful! Could you also add basic test for both? The lv_test_indev.h API can be used in the tests.
|
Test added. I also made rollers emit value changed events for key presses #6008 (comment) and improved the example so the sliders and rollers sync with each other. |
liamHowatt
commented
Apr 15, 2024
|
Thank you! |
FASTSHIFT
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
In response to #6008
Add flags to gridnav for accepting arrow keys only of a certain axis (either left/right or up/down) for grid navigation and send the ignored keys to the focused object.
LV_GRIDNAV_CTRL_HORIZONTAL_MOVE_ONLYLV_GRIDNAV_CTRL_VERTICAL_MOVE_ONLYAdd an example that uses these flags.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.