Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs): add Arduino ESP LittleFS driver #5905

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

PierreRambaud
Copy link
Contributor

Description of the feature or fix

A driver to be able to use Arduino ESP LittleFS file system.

Notes

@PGNetHun PGNetHun changed the title Feat/arduino littlefs driver feat(fs): add Arduino ESP LittleFS driver Mar 18, 2024
@PGNetHun PGNetHun self-requested a review March 18, 2024 20:06
Copy link
Collaborator

@PGNetHun PGNetHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only some minor (precise) wordings are needed.

Kconfig Outdated Show resolved Hide resolved
docs/libs/fs.rst Outdated Show resolved Hide resolved
src/lv_conf_internal.h Show resolved Hide resolved
@PierreRambaud PierreRambaud force-pushed the feat/arduino-littlefs-driver branch from a4e6ec3 to 3a441ad Compare March 19, 2024 06:20
@PierreRambaud PierreRambaud force-pushed the feat/arduino-littlefs-driver branch from 3a441ad to e41ee42 Compare March 19, 2024 07:03
@PGNetHun PGNetHun self-requested a review March 19, 2024 07:45
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! 🎉

Thank you! Can you tell what is the plan with the SD library?

@kisvegabor kisvegabor merged commit f4226cd into lvgl:master Mar 20, 2024
16 checks passed
@PierreRambaud
Copy link
Contributor Author

I'm gonna make it in a few days, sure it'll be ready for the next week!

@PierreRambaud PierreRambaud deleted the feat/arduino-littlefs-driver branch March 21, 2024 11:32
@matixan
Copy link

matixan commented Apr 29, 2024

Hello guys
I'm more than little confused about using this driver. Docs are unclear to me.
How is lv_littlefs_set_handler(...) supposed to work?
What header should I include to use this function, and what is an example parameter?
I want to use this driver with File explorer example for selecting configuration files.
My app is working with SDMMC Arduino library. MCU is ESP32-S3.
I have access to files in my non GUI app, but file explorer gives me error nr 3 when show_dir is called, like it's not correctly initialised.

@PierreRambaud
Copy link
Contributor Author

lv_littlefs_set_handler

The lv_littlefs_set_handler is related to lfs.h driver, not the Arduino one. For lfs.h you have to follow the instruction provided by the original repository: https://github.com/littlefs-project/littlefs

If you have Arduino.h installed, you can use the lvgl configuration like I did here: https://github.com/PierreRambaud/lvgl-arduino-sd-example/blob/master/lib/lv_conf/lv_conf.h#L631 and that's it, you should be able to use it like this: https://github.com/PierreRambaud/lvgl-arduino-sd-example/blob/master/src/arduino-sd.cpp#L42

@matixan
Copy link

matixan commented Apr 29, 2024

Sorry for trouble
Now i see that in master branch there are arduino related files.
I'll check them out.

@PierreRambaud
Copy link
Contributor Author

Sorry for trouble Now i see that in master branch there are arduino related files. I'll check them out.

It will probably be easier, I had a lot of trouble playing with the original lfs.h PierreRambaud/pokegotchi@eec197e 😅

@PierreRambaud PierreRambaud restored the feat/arduino-littlefs-driver branch April 29, 2024 17:00
@PierreRambaud PierreRambaud deleted the feat/arduino-littlefs-driver branch December 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants