Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some code and docs to use v9 API #5876

Merged
merged 2 commits into from
Apr 10, 2024
Merged

chore: update some code and docs to use v9 API #5876

merged 2 commits into from
Apr 10, 2024

Conversation

zylalx1
Copy link
Contributor

@zylalx1 zylalx1 commented Mar 15, 2024

Description of the feature or fix

update most of the remaining code (including demos, examples and tests) and docs using the old API in lv_api_map_v8.h to v9 API

i keep the code using lv_obj_move_foreground and lv_obj_move_background untouched because i think these APIs are nice and easy to use

Notes

demos/music/assets/img_lv_demo_music_cover_1.c Outdated Show resolved Hide resolved
demos/music/assets/img_lv_demo_music_cover_2.c Outdated Show resolved Hide resolved
demos/music/assets/img_lv_demo_music_cover_3.c Outdated Show resolved Hide resolved
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you so much!

Please the fix the missing consts pointed out by @XuNeo and we are good to go from my side!

XuNeo
XuNeo previously approved these changes Mar 19, 2024
FASTSHIFT
FASTSHIFT previously approved these changes Mar 20, 2024
zylalx1 and others added 2 commits March 25, 2024 19:20
@kisvegabor kisvegabor dismissed stale reviews from FASTSHIFT and XuNeo via dd0063c March 25, 2024 18:21
@kisvegabor
Copy link
Member

I've fixed the merge conflicts.

@lvgl-bot
Copy link

lvgl-bot commented Apr 9, 2024

We need some feedback on this pull request.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

@lvgl-bot lvgl-bot added the stale label Apr 9, 2024
@FASTSHIFT FASTSHIFT merged commit 47ec278 into lvgl:master Apr 10, 2024
@zylalx1 zylalx1 deleted the chore_v9_API branch April 10, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants