Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decoder): add image header cache #5407

Merged
merged 8 commits into from
Jan 22, 2024
Merged

feat(decoder): add image header cache #5407

merged 8 commits into from
Jan 22, 2024

Conversation

W-Mai
Copy link
Contributor

@W-Mai W-Mai commented Jan 20, 2024

Description of the feature or fix

Add image decoder header cache

Notes

@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 20, 2024

this pr relies on other prs
merge order:

  1. feat(image_decoder): remove args for open_cb #5402
  2. fix(decoder_dsc): replace decoder_dsc.header with decoder_dsc.decoded->header #5405
  3. feat(image_decoder): simplify lv_image_decoder_get_info/open workflow #5404
  4. feat(decoder): add image header cache #5407

XuNeo
XuNeo approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@XuNeo XuNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

terry0012
terry0012 reviewed Jan 22, 2024
View reviewed changes
src/draw/lv_image_decoder.c Outdated Show resolved Hide resolved
src/draw/lv_image_decoder.c Show resolved Hide resolved
@PGNetHun PGNetHun mentioned this pull request Jan 22, 2024
Merged
PGNetHun
PGNetHun requested changes Jan 22, 2024
View reviewed changes
src/draw/lv_image_decoder.c Outdated Show resolved Hide resolved
kisvegabor
kisvegabor approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update and the reviews!

@kisvegabor kisvegabor merged commit d26eac8 into lvgl:master Jan 22, 2024
16 checks passed
@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 22, 2024 •
edited
Loading

@kisvegabor
Wait, these patches have dependencies. Joining this patch alone will make it difficult for the code to roll back review and so on. Can we merge them one by one?

this pr relies on other prs merge order:

  1. feat(image_decoder): remove args for open_cb #5402
  2. fix(decoder_dsc): replace decoder_dsc.header with decoder_dsc.decoded->header #5405
  3. feat(image_decoder): simplify lv_image_decoder_get_info/open workflow #5404
  4. feat(decoder): add image header cache #5407

@kisvegabor
Copy link
Member

Ok, I'll merge them in this order, but please resolve merge conflicts.

@kisvegabor kisvegabor mentioned this pull request Jan 22, 2024
Merged
@kisvegabor
Copy link
Member

I reverted #5407

@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 22, 2024

In fact, their interdependence is a superposition relationship. If I fix the conflict, it will become an empty patch, so my suggestion is that we quickly revert this patch, and then merge it in order, and then resubmit the image header cache. If it's troublesome, I can ask @FASTSHIFT for help.😁

@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 22, 2024

I reverted #5407

Oh, You are one step faster!

@kisvegabor
Copy link
Member

kisvegabor commented Jan 22, 2024 •
edited
Loading

This one still need to be updated: #5404

@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 22, 2024

This one still need to be updated: #5404

Done, waiting for the CI.

@kisvegabor
Copy link
Member

Please open this PR again to merge it again 🙂

@W-Mai W-Mai mentioned this pull request Jan 22, 2024
Merged
@W-Mai
Copy link
Contributor Author

W-Mai commented Jan 22, 2024

Please open this PR again to merge it again 🙂

It started CI.

  1. feat(image_decoder): add image decoder header cache #5420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terry0012 terry0012 terry0012 left review comments

@XuNeo XuNeo XuNeo approved these changes

@PGNetHun PGNetHun PGNetHun approved these changes

@kisvegabor kisvegabor kisvegabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@W-Mai @kisvegabor @PGNetHun @XuNeo @terry0012