feat(indev): in event-driven mode,needn't continue_reading
#5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisvegabor
requested changes
Jan 17, 2024
…ot required Signed-off-by: YanXiaowei <yanxiaowei@xiaomi.com>
bjsylvia
force-pushed
the
feat-indev-read-event
branch
from
53518d2 to
d9d73d2
Compare
PGNetHun
approved these changes
Jan 18, 2024
kisvegabor
approved these changes
Jan 18, 2024
kisvegabor
added a commit
to kisvegabor/lvgl_fork
that referenced
this pull request
Feb 2, 2024
was broken after lvgl#5363
neuschaefer
added a commit
to neuschaefer/lvgl
that referenced
this pull request
Feb 4, 2024
…ta->continue_reading This relation was introduced but not documented in commit 1881ef2 ("feat(indev): in event-driven mode,needn't `continue_reading` (lvgl#5363)"). The alternative and simpler approach would be to respect data->continue_reading unconditionally. Input devices that don't want to trigger the looping logic should simply never set continue_reading then. The following commits could be reverted: - commit 7e15886 ("fix(sdl): fix keyboard handling (lvgl#5575)") - commit 1881ef2 ("feat(indev): in event-driven mode,needn't `continue_reading` (lvgl#5363)") Commit 7e15886 disproves that continue_reading wasn't needed in event-driven mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help us review this PR! Anyone can approve it or request changes.
Description of the feature or fix
A clear and concise description of what the bug or new feature is.
Checkpoints
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions