fix(obj): readjust scroll after layout when child removed #4916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a child element may cause the current scroll position of the parent to become invalid. This was reported and partially fixed in #3210.
Looking at the original reproducer, there's another way to remove
obj3
that still exhibits the bug:To fix both, add a general mechanism to call
lv_obj_readjust_scroll()
after revalidating the layout. This also fixes (or at least significantly improves) the performance issue in #4908.