Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Allow building LVGL without kconfig #2165

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

amirgon
Copy link
Contributor

@amirgon amirgon commented Mar 24, 2021

Also add ../ to the search path, such that lv_conf.h could be found on parent directory

Related discussion: #1875 (comment)

Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have to edit this script as well, otherwise the change to lv_conf_internal.h will be overriden if we ever regenerate it:

/*Handle special Kconfig options*/
#include "lv_conf_kconfig.h"
#ifdef CONFIG_LV_CONF_SKIP
#define LV_CONF_SKIP
#endif

Also add ../ to the search path, such that lv_conf.h could be found on parent directory

Related discussion: lvgl#1875 (comment)
@amirgon
Copy link
Contributor Author

amirgon commented Mar 24, 2021

You may have to edit this script as well, otherwise the change to lv_conf_internal.h will be overriden if we ever regenerate it:

Thanks @embeddedt.
Done.

@embeddedt embeddedt merged commit 1748798 into lvgl:release/v7 Mar 24, 2021
@embeddedt
Copy link
Member

Merged!

@kisvegabor
Copy link
Member

Thanks. I've cherry-picked it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants