-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test barcode won't work with get_area_cb #4838
Comments
In order to solve this, the decoded image should not be a simple pointer of
/**Describe an image decoding session. Stores data about the decoding*/
typedef struct _lv_image_decoder_dsc_t {
/**The decoder which was able to open the image source*/
lv_image_decoder_t * decoder;
/*A copy of parameters of how this image is decoded*/
lv_image_decoder_args_t * args;
/**The image source. A file path like "S:my_img.png" or pointer to an `lv_image_dsc_t` variable*/
const void * src;
/** Pointer to a buffer where the image's data (pixels) are stored in a decoded, plain format.
* MUST be set in `open` function*/
const uint8_t * img_data;
...
} lv_image_decoder_dsc_t; |
A similar issue is for indexed image, it could decode to ARGB8888 image, which makes it inconsistent with header->cf. Adding |
I don't think it's hacky, but rather a good clean up.
The header here should store data for the decoded image. lvgl/src/draw/lv_image_decoder.h Lines 136 to 137 in 950cebf
However considering it a |
If so, then |
It could use |
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
We need some feedback on this issue. Now we mark this as "stale" because there was no activity here for 14 days. Remove the "stale" label or comment else this will be closed in 7 days. |
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
As there was no activity here for a while we close this issue. But don't worry, the conversation is still here and you can get back to it at any time. So feel free to comment if you have remarks or ideas on this topic. |
Will be fixed in #4948, close it for now. |
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Fix lvgl#4838 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
While debugging CI issue when
LV_BIN_DECODER_RAM_LOAD
is set to0
.The issue is when using get_area_cb, decoder_dsc->img_data becomes not NULL after
img_decode_and_draw
, the next time it's called fromimg_draw_tiled
, It now thinks whole image is available(line 256) becausedecoder_dsc->img_data
is not NULL.lvgl/src/draw/sw/lv_draw_sw_img.c
Lines 256 to 285 in 423c288
I currently hacked the code to mark
img_data
as NULL, so to continue debug CI test fail issues.Perform all steps below and tick them with [x]
Describe the bug
To Reproduce
Expected behavior
Screenshots or video
The text was updated successfully, but these errors were encountered: