Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added creating and editing contacts via device form #69

Merged
merged 12 commits into from
Apr 22, 2020
Merged

Added creating and editing contacts via device form #69

merged 12 commits into from
Apr 22, 2020

Conversation

engylemure
Copy link
Contributor

Considering the existence of native forms existing in IOS and Android, I tried to provide some methods for creating and editing contacts through them.

@lukasgit
Copy link
Owner

@engylemure thanks for your PR. Two issues need to be resolved:

  1. The build is failing with Travis CI.
  2. Please submit your PR to the staging branch (not master).

Thanks!

@engylemure engylemure changed the base branch from master to staging December 23, 2019 16:36
@engylemure
Added the usage of ensureInitialized in the test script
6633c0d 
Added a check for contact existence in the openExistingContact in Android
@engylemure
Copy link
Contributor Author

@lukasgit Sorry for the delay.

@engylemure thanks for your PR. Two issues need to be resolved:

  1. The build is failing with Travis CI.
  2. Please submit your PR to the staging branch (not master).

Thanks!

Solved these issues.
Thanks!

@timekone timekone mentioned this pull request Mar 4, 2020
Closed
@lukasgit
Copy link
Owner

@engylemure my apologies for the late response!

Changes were made in PR #84 to migrate this plugin to android v2 embedding. Those changes affected a few lines of your PR code in ContactsServicePlugin.java.

Can you please update your code and let me know when the PR is ready? Thanks!

@engylemure
Copy link
Contributor Author

@engylemure my apologies for the late response!

Changes were made in PR #84 to migrate this plugin to android v2 embedding. Those changes affected a few lines of your PR code in ContactsServicePlugin.java.

Can you please update your code and let me know when the PR is ready? Thanks!

Sure, it is Ready.

@lukasgit lukasgit merged commit 6f5b623 into lukasgit:staging Apr 22, 2020
@lukasgit
Copy link
Owner

Thank you @engylemure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engylemure @lukasgit