Title extraction from meta + regex fixes #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/luin/readability: Fix indentation. Move whitehouse fixture to the test folder. Remove test folder from npm package. Adds system for creating regression tests.
…x characters (eg. ^)
|
Bump! |
|
Hey @luin. I submitted this over a month ago and there's been no response. Can you let me know what you want to do with this? |
|
Thanks @luin :) |
|
Hi @haroldtreen. Sorry for the very late response! A little busy this month. I checked the code and it's awesome! Just merged it. btw, I added you as a contributor of this repo. 😆 |
|
Woot! Thanks @luin! :D I'm actually going to a programming retreat in September and will be working on Open Source for 3 months. Content extraction has been a fun problem, so I'll probably have more to add. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
getTitleto check the meta tags for titles. (Twitter + Open Graph titles)postbut only if it is at the start of the class/id.How to test:
npm testwith and without the helper changes to verify that they are fixing article extraction for the added tests.Let me know if you have any questions/comments/concerns @luin :).