867/add markdown incident description #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandoned-prototype
requested review from
dismantl,
brianmwaters and
pierwill
dismantl
requested changes
Oct 4, 2021
|
Unless the markdown support is only supposed to be for incident descriptions and not officer descriptions? It appears to work for incident descriptions. |
Yeah, I only implemented it for incidents, but I agree, it makes sense to have the same thing for notes & descriptions for officers as well. Also pretty easy to add with the jinja filter. I am about to update it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #867.
Changes proposed in this pull request:
Tests and linting
I have rebased my changes on current
developpytests pass in the development environment on my local machine
flake8checks pass