Timezone-related improvements #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def thousands_seperator(value: int) -> str: | ||
| """Convert int to string with the appropriately applied commas.""" | ||
| return f"{value:,}" | ||
| app.template_filter("capfirst")(capfirst_filter) |
There was a problem hiding this comment.
I assume these were moved to make testing easier?
sea-kelp
added a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
<!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. --> Several misc timezone-related changes: * Validate input to /timezone * Remove pytz dependency https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html * Include timezone in local_time and local_date_time output * Add tests for jinja filters * Fix typo `thousands_seperator` -> `thousands_separator` * Revert change to make session cookie permanent None! N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
added a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
<!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. --> Several misc timezone-related changes: * Validate input to /timezone * Remove pytz dependency https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html * Include timezone in local_time and local_date_time output * Add tests for jinja filters * Fix typo `thousands_seperator` -> `thousands_separator` * Revert change to make session cookie permanent None! N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
added a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
<!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. --> Several misc timezone-related changes: * Validate input to /timezone * Remove pytz dependency https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html * Include timezone in local_time and local_date_time output * Add tests for jinja filters * Fix typo `thousands_seperator` -> `thousands_separator` * Revert change to make session cookie permanent None! N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
<!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. --> Several misc timezone-related changes: * Validate input to /timezone * Remove pytz dependency https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html * Include timezone in local_time and local_date_time output * Add tests for jinja filters * Fix typo `thousands_seperator` -> `thousands_separator` * Revert change to make session cookie permanent None! N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Several misc timezone-related changes:
thousands_seperator->thousands_separatorNotes for Deployment
None!
Screenshots (if appropriate)
N/A
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.