Move UUID creation to server (not DB) and remove comments #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
requested review from
b-meson,
abandoned-prototype and
null-space-0
michplunkett
changed the title
michplunkett
commented
Aug 24, 2023
Comment on lines
-20
to
-21
| op.execute("CREATE EXTENSION pgcrypto;") | ||
|
|
There was a problem hiding this comment.
Removed the extension addition.
michplunkett
commented
Aug 24, 2023
| op.add_column( | ||
| "users", | ||
| sa.Column( | ||
| "_uuid", | ||
| sa.String(36), | ||
| nullable=False, | ||
| server_default=sa.text("gen_random_uuid()"), |
There was a problem hiding this comment.
Removed the server_default ask, which is the function it was erroring on.
INFO [alembic.runtime.migration] Running upgrade a35aa1a114fa -> 52d3f6a21dd9, add _uuid column to users
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
self.dialect.do_execute(
File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/default.py", line 736, in do_execute
cursor.execute(statement, parameters)
psycopg2.errors.UndefinedFile: could not open extension control file "/usr/share/pgsql/extension/pgcrypto.control": No such file or directory
michplunkett
changed the title
sea-kelp
approved these changes
Aug 24, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
…s#1041) Removed auto-generated Alembic comments from migrations and moved the UUID creation from the database to the server. This strategy, recommended by @sea-kelp, allows us to keep the functionality we want without requiring new instances to add any extensions to their PostgreSQL instance and prevents us from being in a coupled state with a modified PostgreSQL instance. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
…s#1041) Removed auto-generated Alembic comments from migrations and moved the UUID creation from the database to the server. This strategy, recommended by @sea-kelp, allows us to keep the functionality we want without requiring new instances to add any extensions to their PostgreSQL instance and prevents us from being in a coupled state with a modified PostgreSQL instance. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
…s#1041) Removed auto-generated Alembic comments from migrations and moved the UUID creation from the database to the server. This strategy, recommended by @sea-kelp, allows us to keep the functionality we want without requiring new instances to add any extensions to their PostgreSQL instance and prevents us from being in a coupled state with a modified PostgreSQL instance. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
…s#1041) Removed auto-generated Alembic comments from migrations and moved the UUID creation from the database to the server. This strategy, recommended by @sea-kelp, allows us to keep the functionality we want without requiring new instances to add any extensions to their PostgreSQL instance and prevents us from being in a coupled state with a modified PostgreSQL instance. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removed auto-generated Alembic comments from migrations and moved the UUID creation from the database to the server. This strategy, recommended by @sea-kelp, allows us to keep the functionality we want without requiring new instances to add any extensions to their PostgreSQL instance and prevents us from being in a coupled state with a modified PostgreSQL instance.
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.