Add to test coverage and fix label_data form
#1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
requested review from
b-meson,
abandoned-prototype and
null-space-0
3 tasks
michplunkett
changed the title
Officer coverageOfficer and Email coverage
michplunkett
commented
Aug 23, 2023
Comment on lines
+46
to
+47
| <form action="{{ url_for('main.label_data', image_id=image.id, department_id=department.id if department else 0) }}" | ||
| method="post"> |
There was a problem hiding this comment.
This should address the error, @sea-kelp: #968 (comment)
michplunkett
commented
Aug 23, 2023
| <b>Explanation</b>: after matching the officer's name, badge number, or face to the roster, enter the officer's OpenOversight ID here. | ||
| </div> | ||
| </div> | ||
| </form> |
There was a problem hiding this comment.
The closing tag is here, @sea-kelp.
michplunkett
changed the title
Officer and Email coveragelabel_data form
b-meson
approved these changes
Aug 24, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
I added to `Officer` and `Email` coverage in another PR and thought it'd be better to add in its own PR. I also addressed an issue with a broken `<form>` tag. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
I added to `Officer` and `Email` coverage in another PR and thought it'd be better to add in its own PR. I also addressed an issue with a broken `<form>` tag. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
I added to `Officer` and `Email` coverage in another PR and thought it'd be better to add in its own PR. I also addressed an issue with a broken `<form>` tag. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
I added to `Officer` and `Email` coverage in another PR and thought it'd be better to add in its own PR. I also addressed an issue with a broken `<form>` tag. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I added to
OfficerandEmailcoverage in another PR and thought it'd be better to add in its own PR. I also addressed an issue with a broken<form>tag.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.