Prefer widget.callback over stack trace check #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to LiteGraph included a rename of a local function. This value was being checked to prevent unwanted value sets. This has been replaced with widget callback(), which for combo boxes is always called when a value is clicked, regardless of any change.
Known issue w/widget.callback and setter/getter.
ltdrdata
approved these changes
Nov 30, 2024
|
Ok nevermind, I saw now the fix: 1ec3037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent update to LiteGraph included a rename of a local function. This value was being checked to limit calls to the widget value setter.
Behaviour has been replaced with widget
callback(), which for combo boxes is always called (once!) when a value is clicked, regardless of any change.