storage: merge iterator implementation #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a new merge iterator implementation to the storage package. Compared to the old multi iterator, the new implementation iterates in sorted order over the subiterators and exhibits correct behavior when seeking over subiterators. * Adds Err() method on Iterator interface. Err() should be called after finishing iteration to check for possible errors.
db7
approved these changes
Apr 30, 2019
frairon
reviewed
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of the Err() method on the Iterator interface might break some code implementing custom iterators. Also, existing code should be updated to check the possible error after iteration by calling the
Err(). Previous implementation didn't surface the error, causing some possible errors to go unseen.Adds a new merge iterator implementation to the storage package.
Compared to the old multi iterator, the new implementation
iterates in sorted order over the subiterators and exhibits
correct behavior when seeking over subiterators.
Adds Err() method on Iterator interface. Err() should be called
after finishing iteration to check for possible errors.
Fixes #178