Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of db7/kazoo-go and subsequent repo deletion breaks previous builds #154

Closed
dancompton opened this issue Oct 29, 2018 · 4 comments
Closed

Comments

@dancompton
Copy link

dancompton commented Oct 29, 2018

This change made by contributor @db7 and the subsequent removal of github.com/db7/kazoo-go repository breaks glide/dep vendored versions of lovoo/goka due to inability to fetch db7/kazoo-go. Broken version below:

- name: github.com/lovoo/goka
  version: d58a3143ca343a51a72459a6de8ad138c219c546

API changes likely make upgrading difficult.

dancompton pushed a commit to zenreach/kazoo-go that referenced this issue Oct 29, 2018
@dancompton
Copy link
Author

closing this because I've fixed it with a glide mirror

@db7
Copy link
Collaborator

db7 commented Oct 29, 2018

@dan-compton thanks for reporting. The changes that were in db7/kazoo-go are merged upstream, so I updated goka to use that repo instead. I probably shouldn't have deleted my fork, though. I reforked the repo in the hope that your build process passes again. Could you check that please? Or if you have another suggestion, let me know.

@dancompton
Copy link
Author

dancompton commented Oct 31, 2018

@db7 We're sticking with the fork + glide mirror until we update goka as the relevant changes to tooling have already been merged internally. Thanks though. As for others, it will work fine as long as the commit sha is the same. Otherwise, it would need to be discovered and updated in their X.lock file

@db7
Copy link
Collaborator

db7 commented Oct 31, 2018

Thanks for the info. I restored the db7/kazoo-go with the lastest local repo I could find. Hopefully that fixes the problem for other people. This was an unfortunate repo removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants