ISSUE-15 / Fix double transitions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kristoiv Please have a look if you have time. Does this solve the issue in a thread safe manner? |
|
Thanks for coming back so soon. I totally get your situation, I'm in a similar situation but finally got a few minutes between sprints to give it a go. Could not use your branch directly, which I'm sorry for. I appreciate any feedback. Will also try to enable the race flag on CI now. |
maxekman
force-pushed
the
ISSUE-15/double-transitions
branch
2 times, most recently
from
bcf023e to
c0848b9
Compare
maxekman
force-pushed
the
ISSUE-15/double-transitions
branch
from
c0848b9 to
d439805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue, as long as the test cases exposes it correctly.
Thanks to @kristoiv for providing the base for this PR.
Fixes #15