Limit displayed override duration to 'Hours of Prediction' after current time #363
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StatusThis PR fixes the problem reported in Issue #354 Code ReviewThe proposed change will use duration of prediction for showing the currently acting override. This will limit how far in the future all overrides will be shown. Especially important for Trio (soon to be released as 1.0) which uses 30 days to indicate an indefinite override duration. TestBegin without the modification in this PR. Graphic below shows before applying the PR on the left and with the PR on the right.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #354
This PR limits displayed override duration to 'Hours of Prediction' after current time.