Sorry. Why are we removing this toggle ?

Sorry. Why are we removing this toggle ?

Hi, thanks for commenting!
It is removed in order to clean up the gui, it is a common error to forget to turn on this setting. I believe it was from a time when LF crashed very easily when there was bad data in Nightscout.
Are you using it, and for what?

Edited after PM with @bjorkert.
This is desired behavior.

A blank NS table indicates a problem downloading data from the URL.

No NS table indicates the NS URL is empty.

Test Results:

• If NS URL is present and valid, NS table displayed and has data
• If NS URL is present but not valid (e.g. bad token), the NS table is still shown but is empty (glucose coming from Dexcom for this test)
• repeat but with no Dexcom credentials, BG shows ---, NS table displayed but blank
• NS URL is blank, then NS table is not displayed

I have it toggled on, because I use NS and want the NS data downloaded.
So, I assume this is proposing to remove the toggle and the download data (if available) is always 'enabled' ?
Fine with me if thats the case.

And while you are at it. This is an unexpected consequence of a PR a couple of times ago where you sanitized the URL.

Try typing in https://sitename, instead of pasting in a URL, and you'll notice it won't allow you to enter the / characters.

I have it toggled on, because I use NS and want the NS data downloaded. So, I assume this is proposing to remove the toggle and the download data (if available) is always 'enabled' ? Fine with me if thats the case.

Yes, exactly. My fault, I should have written a better PR description of this. So after this change, it will always try to download Nightscout data, just as if the switch would have been on.

And while you are at it. This is an unexpected consequence of a PR a couple of times ago where you sanitized the URL.

Try typing in https://sitename, instead of pasting in a URL, and you'll notice it won't allow you to enter the / characters.

I feel like, perhaps, your comments are for a different PR ;)
#290

I have it toggled on, because I use NS and want the NS data downloaded. So, I assume this is proposing to remove the toggle and the download data (if available) is always 'enabled' ? Fine with me if thats the case.

Yes, exactly. My fault, I should have written a better PR description of this. So after this change, it will always try to download Nightscout data, just as if the switch would have been on.

Sure, I figured, just wanted to make sure. I also assume that if there is no NS url entered. it won't attempt to download every few minutes ?

I have it toggled on, because I use NS and want the NS data downloaded. So, I assume this is proposing to remove the toggle and the download data (if available) is always 'enabled' ? Fine with me if thats the case.

Yes, exactly. My fault, I should have written a better PR description of this. So after this change, it will always try to download Nightscout data, just as if the switch would have been on.

Sure, I figured, just wanted to make sure. I also assume that if there is no NS url entered. it won't attempt to download every few minutes ?

Yes, blank URL would be the same as toggling the removed toggle off.