Login fields respect $config->validFields #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah shoot I just noticed those files were indent with spaces and I submitted tabs. Let me know if you'd like me to redo that. I thought this repo was tabs but maybe I just never paid attention... |
|
@lonnieezell have you had a chance to look at this? I would like to implement this change in a current project, which I can do locally or through the repo (depending on if you think it is appropriate as a general change), but I need to make a decision. |
|
Sorry - this one slipped through the cracks. In the middle of moving to a new house and trying to sell the current one so everything's a bit crazy on this side. This looks fine. |
|
No worries! Moving is a $&%*# - take care of yourself and don't let us hecklers get to you. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Views\login and Controllers\AuthController to accept a username if it is configured in
$config->validFields. The login form will switch its type between text and email depending on the config value, and AuthController checks for a valid email to use when attempting the login call.