Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong translation #410

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix wrong translation #410

merged 2 commits into from
Jul 16, 2021

Conversation

nynsen
Copy link
Contributor

@nynsen nynsen commented Jul 15, 2021

Just a small fix, pretty self-explanatory.

Also I am not sure about "Registrati" and "Hai già un account?" which are technically correct, but non coherent.
If we use the verb "Registrati" for register I think alreadyRegistered then should be "Sei già registrato?".
An alternative could be to use "Crea un account" for register and "Hai già un account?" (Do you already have an account?) for alreadyRegistered.

Just a small fix, pretty self-explanatory.

Also I am not sure about "Registrati" and "Hai già un account?" which are technically correct, but non coherent.
If we use the verb "Registrati" for `register` I think `alreadyRegistered` then should be "Sei già registrato?".
An alternative could be to use "Crea un account" for `register` and "Hai già un account?" (_Do you already have an account?_) for `alreadyRegistered`.
@MGatner
Copy link
Collaborator

MGatner commented Jul 15, 2021

If you are proficient in Italian I am happy for you to propose improvements to any of this. Perhaps if @Vizzielli is around you two could have a conversation.

@nynsen
Copy link
Contributor Author

nynsen commented Jul 15, 2021

Thanks for poking the original author, I'll let him some time to reply.

@Vizzielli
Copy link
Contributor

If we use the verb "Registrati" for register I think alreadyRegistered then should be "Sei già registrato?".

Agree

@MGatner MGatner merged commit 41178b2 into lonnieezell:develop Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants