Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter parameters don't seem to be in CI4 #38

Closed
MGatner opened this issue Apr 23, 2019 · 3 comments
Closed

Filter parameters don't seem to be in CI4 #38

MGatner opened this issue Apr 23, 2019 · 3 comments

Comments

@MGatner
Copy link
Collaborator

MGatner commented Apr 23, 2019

Revisiting #30, the auth filters don't seem to be working. Tracking it down, it looks like $params is empty no matter what is passed. If I'm understanding system/Filters/Filters.php correctly, it looks like only the request object is passed in and no additional parameters:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Filters/Filters.php#L150

Is this something still coming down the pipe? or incorrectly missing? or am I misunderstanding?
@lonnieezell
Copy link
Owner

Should be handled already. Don't have time to investigate too far at the moment, but should be handled by the getFilterForRoute() method of RouteCollection. Though a quick search of RouteCollection and I'm not seeing where that filter is saved at. Hmmm...

@MGatner
Copy link
Collaborator Author

MGatner commented Apr 24, 2019

I see it in this historic commit, but it seems to have been overwritten since then:
codeigniter4/CodeIgniter4@adce491#diff-63f8289a599089d6c44102ec8149bec1

@lonnieezell
Copy link
Owner

I've merged your fix for CI core, so this should be working now.

@MGatner MGatner closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lonnieezell @MGatner