Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application view files do not override packaged views. #17

Closed
fefo-p opened this issue Aug 26, 2018 · 2 comments
Closed

Application view files do not override packaged views. #17

fefo-p opened this issue Aug 26, 2018 · 2 comments

Comments

@fefo-p
Copy link
Contributor

fefo-p commented Aug 26, 2018

When installing with spark several files are copied to App namespace and a conversion is made dealing with their namespaces.
However, when App view-files are loaded, several path error appear as namespace get converted to Auth\Views\etc... instead of \App\Views\Auth\etc...

<?= view('\App\Views\Auth\_header') ?>

This happens in all of the Auth View files, but _footer, _message_block and _navbar
MGatner added a commit to MGatner/myth-auth that referenced this issue Apr 23, 2019
@MGatner
Use full app namespace during publish; fix for lonnieezell#17
3837dbb
@MGatner
Copy link
Collaborator

MGatner commented Apr 23, 2019

You're absolutely correct; sending a PR.

lonnieezell added a commit that referenced this issue Apr 24, 2019
@lonnieezell
Merge pull request #37 from MGatner/fix-publish-view-namespace
2618d6d 
Fix for #17 (low priority)
@MGatner
Copy link
Collaborator

MGatner commented Apr 24, 2019

@lonnieezell this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lonnieezell @MGatner @fefo-p