-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): support recurring and ondemand full backup #2709
feat(backup): support recurring and ondemand full backup #2709
Conversation
97fecb4
to
e9de905
Compare
4d99c6c
to
64b4d30
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
9c979dc
to
a480c0d
Compare
a480c0d
to
82b847a
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
1 similar comment
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ba772b7
to
0307a44
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
1510810
to
bcd7246
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM.
8ed2fb4
to
3e96ecb
Compare
3e96ecb
to
bd8339c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bd8339c
to
913999d
Compare
913999d
to
7247efd
Compare
7247efd
to
2f02196
Compare
ref: longhorn/longhorn 7070 Signed-off-by: Jack Lin <jack.lin@suse.com>
2f02196
to
146db22
Compare
ref: longhorn/longhorn#7070
backupstore: If the backup has the parameter
backupmodea: full
, it will pretend there is no last backup, and backup all the blocks of the current volume.longhorn-manager:
RecurringJob app
.Spec.Parameters
recurringJob.Status.ExecutionCount
, +1 , then update it backup to the statusjob.executionCount%interval == 0
Backup
.Spec.Parameters
.Status.NewlyUploadedDataSize
and.Status.ReUploadedDataSize
to each Backup. So user can know the data transfer size for each Backup to trace the cost.Webhook
Backup.Spec.Parameters
: only support"backup-mode: full/incremental"
RecurringJob.Spec.Parameters
: only support"full-backup-interval: N"
CRD
.Spec.Parameters
to Backup.Spec.Parameters
to RecurringJob.Status.BackupCount
to BackupVolume..Status.NewlyUploadedDataSize
and.Status.ReUploadedDataSize
to BackupAPI
Parameters
to theSnapshotInput{}
BackupCount
toBackupVolume{}