Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backup): support full backup #1119

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(backup): support full backup #1119

merged 1 commit into from
Jun 25, 2024

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented May 31, 2024 •
edited
Loading

ref: longhorn/longhorn#7070

  • add new parameter parameters to the createBackup() function
  • pass it from proxy -> task -> replica client

Depends on PRs:

@ChanYiLin ChanYiLin requested review from innobead and derekbit May 31, 2024 07:44
@ChanYiLin ChanYiLin self-assigned this May 31, 2024
@ChanYiLin ChanYiLin marked this pull request as draft May 31, 2024 07:45
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup_re2 branch 4 times, most recently from bfe9818 to 6493b5e Compare May 31, 2024 08:24
@ChanYiLin ChanYiLin mentioned this pull request May 31, 2024
Merged
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup_re2 branch from 6493b5e to fc94e36 Compare May 31, 2024 08:55
@ChanYiLin ChanYiLin mentioned this pull request May 31, 2024
Merged
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup_re2 branch from fc94e36 to f5fea6a Compare May 31, 2024 10:10
@ChanYiLin ChanYiLin mentioned this pull request Jun 3, 2024
Closed
@mergify Mergify
Copy link

mergify bot commented Jun 7, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup_re2 branch from f5fea6a to ecb64ac Compare June 24, 2024 08:50
@ChanYiLin
feat(backup): support full backup
8808f15 
ref: longhorn/longhorn 7070

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup_re2 branch from ecb64ac to 8808f15 Compare June 24, 2024 08:54
@ChanYiLin ChanYiLin marked this pull request as ready for review June 24, 2024 08:55
derekbit
derekbit approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit b7f9516 into longhorn:master Jun 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@innobead innobead Awaiting requested review from innobead

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChanYiLin @derekbit