Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT][UI] Attach table search keyword to URL on Backup pages #9974

Closed
houhoucoop opened this issue Dec 13, 2024 · 4 comments
Closed

[IMPROVEMENT][UI] Attach table search keyword to URL on Backup pages #9974

houhoucoop opened this issue Dec 13, 2024 · 4 comments
Assignees
@chriscchien @houhoucoop
Labels
area/backup-store Remote backup store related area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function priority/1 Highly recommended to implement or fix in this release (managed by PO) require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone
v1.8.0

Comments

@houhoucoop
Copy link

houhoucoop commented Dec 13, 2024 •
edited
Loading

Is your improvement request related to a feature? Please describe (👍 if you like this request)

Currently, the search keyword is not reflected in the URL for tables on the Backup page, unlike other pages.

Describe the solution you'd like

The search keyword should append to the URL as a query parameter, allowing direct access to filtered results, e.g.

Describe alternatives you've considered

N/A

Additional context

N/A
@houhoucoop houhoucoop added area/ui UI related like UI or CLI require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function labels Dec 13, 2024
@houhoucoop houhoucoop self-assigned this Dec 13, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Dec 13, 2024
@houhoucoop houhoucoop added this to the v1.8.0 milestone Dec 13, 2024
@houhoucoop houhoucoop moved this from New Issues to Analysis and Design in Longhorn Sprint Dec 13, 2024
@houhoucoop houhoucoop changed the title [IMPROVEMENT][UI] Attach table search keyword to URL on Backup and Backing Image pages [IMPROVEMENT][UI] Attach table search keyword to URL on Backup pages Dec 13, 2024
@a110605 a110605 mentioned this issue Dec 13, 2024
Closed
2 tasks
@derekbit derekbit added area/backup-store Remote backup store related priority/1 Highly recommended to implement or fix in this release (managed by PO) labels Dec 13, 2024
@houhoucoop houhoucoop moved this from Analysis and Design to Implement in Longhorn Sprint Dec 16, 2024
@houhoucoop houhoucoop mentioned this issue Dec 16, 2024
Merged
3 tasks
@houhoucoop houhoucoop moved this from Implement to Review in Longhorn Sprint Dec 17, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 17, 2024 •
edited by houhoucoop
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Verified that the search keyword is appended to the URL and the table reflects the filter from URL query parameters on the Backup pages.
Screenshot 2024-12-16 at 12 35 22 PM (2)
Screenshot 2024-12-16 at 12 35 14 PM (2)

Verified that the search keyword is NOT appended to the URL on the Backing image pages.
Screenshot 2024-12-16 at 12 41 02 PM (2)

Verified ws functionality: changes to backup backing images on the Backing Image page are automatically reflected on the Backup page.
Screenshot 2024-12-16 at 12 43 37 PM (2)

@houhoucoop houhoucoop moved this from Review to Ready For Testing in Longhorn Sprint Dec 17, 2024
@a110605 a110605 moved this from Ready For Testing to Review in Longhorn Sprint Dec 17, 2024
@a110605 a110605 moved this from Review to Ready For Testing in Longhorn Sprint Dec 17, 2024
@a110605 a110605 moved this from Ready For Testing to Review in Longhorn Sprint Dec 17, 2024
@derekbit
Copy link
Member

@houhoucoop ready for testing?

@houhoucoop
Copy link
Author

The issue becomes invalid after multiple backup target backend PRs are merged.
Andy addressed it in PR #755, but the query parameters will be different.
e.g. ?field=name&value=pvc#volume becomes ?field=volumeName&value=pvc#volume.
I'm not sure how to proceed in this case, any suggestions? cc @a110605

@houhoucoop houhoucoop moved this from Review to Ready For Testing in Longhorn Sprint Dec 19, 2024
@chriscchien chriscchien moved this from Ready For Testing to Testing in Longhorn Sprint Dec 23, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn master(longhorn/longhorn-ui@ddfa9dd) v1.8.x(longhorn/longhorn-ui@ebcf89e)

Search keyword appeared on Backup pages URL correctly.

@github-project-automation github-project-automation bot moved this from Testing to Closed in Longhorn Sprint Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriscchien chriscchien

@houhoucoop houhoucoop

Labels
area/backup-store Remote backup store related area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function priority/1 Highly recommended to implement or fix in this release (managed by PO) require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.8.0
Development

No branches or pull requests
4 participants
@derekbit @longhorn-io-github-bot @chriscchien @houhoucoop