Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Why is it not possible to change the replica count in v2 longhorn volume? #9805

Closed
derekbit opened this issue Nov 14, 2024 Discussed in #9804 · 5 comments
Closed

[IMPROVEMENT] Why is it not possible to change the replica count in v2 longhorn volume? #9805

derekbit opened this issue Nov 14, 2024 Discussed in #9804 · 5 comments
Assignees
@hookak @chriscchien
Labels
area/admission-webhook Kubernetes validation and mutating admission webhooks area/v2-data-engine v2 data engine (SPDK) backport/1.7.3 kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO)
Milestone
v1.8.0

Comments

@derekbit
Copy link
Member

Discussed in #9804

Originally posted by hookak November 14, 2024
Hello,
I'd like to manually adjust the replica count for each v2 LHV, but it prevented by a wehbook
To change the replica count for v2 LHV is already possible during node eviction.
The replica count of v2 LHV changes in the sequence n->n+1->n.
What is the reason for this restriction?
@derekbit derekbit added kind/bug priority/0 Must be implement or fixed in this release (managed by PO) area/v2-data-engine v2 data engine (SPDK) backport/1.7.3 labels Nov 14, 2024
@derekbit derekbit added this to the v1.8.0 milestone Nov 14, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Nov 14, 2024
@derekbit
Copy link
Member Author

cc @hookak

@github-actions github-actions bot mentioned this issue Nov 14, 2024
Closed
@derekbit derekbit mentioned this issue Nov 14, 2024
Merged
@derekbit
Copy link
Member Author

@hookak Can I assign the ticket to you? Then, you will be the contributor of the ticket and its associated PRs. Thank you.

@hookak
Copy link

hookak commented Nov 14, 2024

Of course, it’s my pleasure. Thanks @derekbit

@derekbit derekbit moved this from New Issues to Review in Longhorn Sprint Nov 14, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Nov 14, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create a v2 volume with 3 replicas
  2. Before the fix, the v2 volume's numberOfReplicas cannot be updated.
  3. After the fix, the v2 volume's numberOfReplicas can be updated.

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#3268

  • Which areas/issues this PR might have potential impacts on?
    Area: replica scheduler
    Issues

@mergify mergify bot mentioned this issue Nov 14, 2024
Merged
@derekbit derekbit moved this from Review to Ready For Testing in Longhorn Sprint Nov 14, 2024
@derekbit derekbit added the area/admission-webhook Kubernetes validation and mutating admission webhooks label Nov 14, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn v1.8.0-dev-20241117 (longhorn/longhorn-manager@470b53c)

V2 volume numberOfReplicas can be updated, replica rebuilding worked well after the replica count change.

@github-project-automation github-project-automation bot moved this from Testing to Closed in Longhorn Sprint Nov 25, 2024
@derekbit derekbit changed the title [BUG] Why is it not possible to change the replica count in v2 longhorn volume? [IMPROVEMENT] Why is it not possible to change the replica count in v2 longhorn volume? Dec 18, 2024
@derekbit derekbit added kind/improvement Request for improvement of existing function and removed kind/bug labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hookak hookak

@chriscchien chriscchien

Labels
area/admission-webhook Kubernetes validation and mutating admission webhooks area/v2-data-engine v2 data engine (SPDK) backport/1.7.3 kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO)
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.8.0
Development

No branches or pull requests
4 participants
@derekbit @hookak @longhorn-io-github-bot @chriscchien