Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.6.4][BUG] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails #9625

Closed
github-actions bot opened this issue Oct 12, 2024 · 2 comments
Closed

[BACKPORT][v1.6.4][BUG] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails #9625

github-actions bot opened this issue Oct 12, 2024 · 2 comments
Assignees
@yangchiu @derekbit
Labels
area/node-drain Longhorn reaction during draining nodes kind/backport Backport request kind/bug kind/regression Regression which has worked before priority/0 Must be implement or fixed in this release (managed by PO) reproduce/always 100% reproducible require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Milestone
v1.6.4

Comments

@github-actions
Copy link

backport #9616
@github-actions github-actions bot added area/node-drain Longhorn reaction during draining nodes kind/backport Backport request kind/bug kind/regression Regression which has worked before priority/0 Must be implement or fixed in this release (managed by PO) reproduce/always 100% reproducible require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade) labels Oct 12, 2024
@github-actions github-actions bot added this to the v1.6.4 milestone Oct 12, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Oct 12, 2024
@mantissahz mantissahz moved this from New Issues to Review in Longhorn Sprint Oct 14, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Oct 14, 2024 •
edited by mantissahz
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  • Run negative test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at
    fix: fix node readiness condition logic (backport #3201) longhorn-manager#3210

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@mantissahz mantissahz assigned derekbit and unassigned mantissahz Oct 14, 2024
@derekbit derekbit changed the title [BACKPORT][v1.6.4][BUG][v1.7.x] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails [BACKPORT][v1.6.4] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails Oct 14, 2024
@derekbit derekbit changed the title [BACKPORT][v1.6.4] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails [BACKPORT][v1.6.4][BUG] Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes fails Oct 14, 2024
@mantissahz mantissahz moved this from Review to Ready For Testing in Longhorn Sprint Oct 15, 2024
@yangchiu
Copy link
Member

Verification passed on v1.6.x-head (longhorn-manager 8fa8bcf). Test case Stopped replicas on deleted nodes should not be counted as healthy replicas when draining nodes passed.

@github-project-automation github-project-automation bot moved this from Ready For Testing to Closed in Longhorn Sprint Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangchiu yangchiu

@derekbit derekbit

Labels
area/node-drain Longhorn reaction during draining nodes kind/backport Backport request kind/bug kind/regression Regression which has worked before priority/0 Must be implement or fixed in this release (managed by PO) reproduce/always 100% reproducible require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.4
Development

No branches or pull requests
4 participants
@yangchiu @derekbit @mantissahz @longhorn-io-github-bot