Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Allow specify data engine version for the default storageclass during Helm installation #9584

Closed
shuo-wu opened this issue Oct 7, 2024 · 2 comments
Closed

[IMPROVEMENT] Allow specify data engine version for the default storageclass during Helm installation #9584

shuo-wu opened this issue Oct 7, 2024 · 2 comments
Assignees
@shuo-wu @chriscchien
Labels
area/chart Helm chart related backport/1.7.2 kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone
v1.8.0

Comments

@shuo-wu
Copy link
Contributor

shuo-wu commented Oct 7, 2024

Is your improvement request related to a feature? Please describe (👍 if you like this request)

It's better to explicitly provide option dataEngine for the default storageclass during Helm installation so that users don't need to
manually modify it later

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@shuo-wu shuo-wu added require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function area/chart Helm chart related require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Oct 7, 2024
@shuo-wu shuo-wu added this to the v1.8.0 milestone Oct 7, 2024
@shuo-wu shuo-wu self-assigned this Oct 7, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Oct 7, 2024
@shuo-wu shuo-wu mentioned this issue Oct 7, 2024
Merged
@shuo-wu shuo-wu moved this from New Issues to Review in Longhorn Sprint Oct 7, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Oct 7, 2024 •
edited by shuo-wu
Loading

Pre Ready-For-Testing Checklist

  1. During helm installation with the chart containing the above PR, set field --set persistence.dataEngine=v2
  2. After installation, check if the default storageclass has parameter dataEngine: v2
  3. Set up v2 env (by enabling the v2 engine settings and adding block disks)
  4. Deploy a workload using Longhorn volume
  5. Make sure the v2 volume can be created, attached, and the workload is fine

@innobead innobead changed the title [IMPROVEMENT][Chore] Allow specify data engine version for the default storageclass during Helm installation [IMPROVEMENT] Allow specify data engine version for the default storageclass during Helm installation Oct 14, 2024
@mergify mergify bot mentioned this issue Oct 14, 2024
Merged
@github-actions github-actions bot mentioned this issue Oct 14, 2024
Closed
@shuo-wu shuo-wu moved this from Review to Ready For Testing in Longhorn Sprint Oct 16, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn v1.8.0-dev-20241020 (a1ddba3)

Floowing test steps, default storageclass longhorn has parameter dataEngine: v2. After install complete, dynamic provision v2 volume using starageclass longhorn success without any problems.

@github-project-automation github-project-automation bot moved this from Testing to Closed in Longhorn Sprint Oct 21, 2024
@derekbit derekbit removed the require/doc Require updating the longhorn.io documentation label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuo-wu shuo-wu

@chriscchien chriscchien

Labels
area/chart Helm chart related backport/1.7.2 kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.8.0
Development

No branches or pull requests
5 participants
@innobead @derekbit @shuo-wu @longhorn-io-github-bot @chriscchien