Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.6.3][IMPROVEMENT] Improve and simplify chart values.yaml #8636

Closed
github-actions bot opened this issue May 24, 2024 · 2 comments
Closed

[BACKPORT][v1.6.3][IMPROVEMENT] Improve and simplify chart values.yaml #8636

github-actions bot opened this issue May 24, 2024 · 2 comments
Assignees
@ChanYiLin @chriscchien
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/chart Require updating (chart) manifests in longhorn, longhorn-manager, charts repos require/doc Require updating the longhorn.io documentation
Milestone
v1.6.3

Comments

@github-actions
Copy link

backport #5089
@github-actions github-actions bot added area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/chart Require updating (chart) manifests in longhorn, longhorn-manager, charts repos require/doc Require updating the longhorn.io documentation labels May 24, 2024
@github-actions github-actions bot added this to the v1.6.3 milestone May 24, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented May 24, 2024 •
edited by ChanYiLin
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Helm install with global value will work for Manager, UI, Driver Deployer components
global:
  # -- Toleration for nodes that can run user-deployed Longhorn components (Manager, UI, Driver Deployer).
  tolerations: []
  # -- Node selector for nodes that can run user-deployed Longhorn components (Manager, UI, Driver Deployer).
  nodeSelector: {}
  1. Fresh install again and specify each components with its own tolerations and nodeSelector, the global setting will be overriwrten
longhornManager:
  log:
    format: plain
  priorityClass: *defaultPriorityClassNameRef
  tolerations: []
  nodeSelector: {}
  serviceAnnotations: {}

longhornDriver:
  priorityClass: *defaultPriorityClassNameRef
  tolerations: []
  nodeSelector: {}

longhornUI:
  replicas: 2
  priorityClass: *defaultPriorityClassNameRef
  tolerations: []
  nodeSelector: {}

PR:

@ChanYiLin ChanYiLin mentioned this issue May 24, 2024
Merged
@derekbit derekbit moved this to Ready For Testing in Longhorn Sprint Aug 3, 2024
@chriscchien chriscchien self-assigned this Aug 15, 2024
@chriscchien
Copy link
Contributor

Verified pass on v1.6.x (longhorn 6b78638) with test steps, global setting worked well and will be overwritten by components setting(longhornManager, longhornDriver and longhornUI)

@github-project-automation github-project-automation bot moved this from Ready For Testing to Closed in Longhorn Sprint Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChanYiLin ChanYiLin

@chriscchien chriscchien

Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/chart Require updating (chart) manifests in longhorn, longhorn-manager, charts repos require/doc Require updating the longhorn.io documentation
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.3
Development

No branches or pull requests
3 participants
@ChanYiLin @longhorn-io-github-bot @chriscchien