Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Remove unused process manager connection in longhorn-manager #7783

Closed
derekbit opened this issue Jan 25, 2024 · 2 comments
Closed

[IMPROVEMENT] Remove unused process manager connection in longhorn-manager #7783

derekbit opened this issue Jan 25, 2024 · 2 comments
Assignees
@derekbit @chriscchien
Labels
backport/1.5.4 kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone
v1.6.0

Comments

@derekbit
Copy link
Member

derekbit commented Jan 25, 2024 •
edited
Loading

Is your improvement request related to a feature? Please describe (👍 if you like this request)

The longhorn-manager communicates with the process manager gRPC service in an older instance-manager (apiVersion < 4). For a newer instance-manager, however, the longhorn-manager only needs to interact with the instance gRPC service. As a result, there is no requirement for the longhorn-manager to establish a connection to the process manager.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@derekbit derekbit added require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Jan 25, 2024
@derekbit derekbit added this to the v1.6.0 milestone Jan 25, 2024
@derekbit derekbit self-assigned this Jan 25, 2024
@derekbit derekbit mentioned this issue Jan 25, 2024
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 25, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create attached volumes in v1.4.x cluster
  2. Upgrade Longhorn-system to master-head or v1.6.x. Do not update upgrade the volume's engine image.
  3. Detach the volume and the detachment should work.
  4. Delete the volume. The operation should work.
  5. Create a new volume and verify the attachment and detachement.

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2523

  • Which areas/issues this PR might have potential impacts on?
    Area: longhorn-manager, longhorn-instance-manager, gRPC
    Issues

@derekbit derekbit mentioned this issue Jan 25, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 25, 2024
Closed
@innobead innobead assigned chriscchien and unassigned roger-ryao Jan 25, 2024
@chriscchien
Copy link
Contributor

Verifed pass on longhorn master(longhorn-manager c7d9d7), longhorn v1.6.x(longhorn-manager 1640c5)

After upgrade from v1.4.x to master-head and to v1.6.x

  • The volume with old engine can perform detach and reattach operations without any problem.
  • Create/Attach/Detach new v1 and v2 volumes success.

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@chriscchien chriscchien

Labels
backport/1.5.4 kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.0
Development

No branches or pull requests
4 participants
@derekbit @longhorn-io-github-bot @chriscchien @roger-ryao