Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][v1.6.0-rc2] rwx volume failed to execute trim filesystem #7768

Closed
roger-ryao opened this issue Jan 24, 2024 · 4 comments
Closed

[BUG][v1.6.0-rc2] rwx volume failed to execute trim filesystem #7768

roger-ryao opened this issue Jan 24, 2024 · 4 comments
Assignees
@c3y1huang @roger-ryao
Labels
area/volume-rwx Volume RWX related component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) kind/bug reproduce/always 100% reproducible require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Milestone
v1.6.0

Comments

@roger-ryao
Copy link

Describe the bug

The rwx volume failed to execute trim filesystem and received an error as shown in the message and screenshot.

unable to trim filesystem for volume pvc-156966f3-daab-4e2e-a1f8-3531c8e233c8: rpc error: code = Internal desc = failed to execute: /usr/bin/nsenter [nsenter --mount=/host/proc/1446380/ns/mnt --net=/host/proc/1446380/ns/net fstrim /export/pvc-156966f3-daab-4e2e-a1f8-3531c8e233c8], output , stderr fstrim: cannot get realpath: /export/pvc-156966f3-daab-4e2e-a1f8-3531c8e233c8: No such file or directory : exit status 1

Screenshot_20240124_124627

To Reproduce

  1. create rwx volume and deploy POD
  2. rwx volume execute trim filesystem

Expected behavior

rwx volume should be executed trim filesystem without error.

Support bundle for troubleshooting

supportbundle_afef4354-d6b0-4877-b5c7-0bcb93bb31b4_2024-01-24T04-46-52Z.zip

Additional context
@roger-ryao roger-ryao added kind/bug severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade) reproduce/always 100% reproducible require/qa-review-coverage Require QA to review coverage require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Jan 24, 2024
@roger-ryao roger-ryao added this to the v1.6.0 milestone Jan 24, 2024
@derekbit
Copy link
Member

derekbit commented Jan 24, 2024 •
edited
Loading

Trim command is issued in a wrong namespace.
https://github.com/longhorn/longhorn-share-manager/blob/master/pkg/rpc/server.go#L108-L118
cc @c3y1huang

@c3y1huang c3y1huang self-assigned this Jan 24, 2024
@c3y1huang c3y1huang mentioned this issue Jan 24, 2024
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 24, 2024 •
edited by c3y1huang
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: issue description

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at:

  • Which areas/issues this PR might have potential impacts on?
    Area RWX volume, fstrim
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at test(recurring-job/fstrim): test RWO and RWX volume longhorn-tests#1689
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@c3y1huang c3y1huang added area/volume-rwx Volume RWX related component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated labels Jan 24, 2024
@github-actions github-actions bot mentioned this issue Jan 24, 2024
Closed
@c3y1huang c3y1huang mentioned this issue Jan 24, 2024
Merged
@roger-ryao roger-ryao self-assigned this Jan 24, 2024
@innobead
Copy link
Member

Good catch @roger-ryao

@roger-ryao
Copy link
Author

roger-ryao commented Jan 25, 2024 •
edited
Loading

Verified on master-head 20240125

The test steps
#7768 (comment)

Result Passed

@james-munson james-munson mentioned this issue May 6, 2024
Closed
This was referenced May 7, 2024
Merged
Merged
Merged
@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c3y1huang c3y1huang

@roger-ryao roger-ryao

Labels
area/volume-rwx Volume RWX related component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) kind/bug reproduce/always 100% reproducible require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.0
Development

No branches or pull requests
5 participants
@innobead @derekbit @c3y1huang @longhorn-io-github-bot @roger-ryao