Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Increase the hugepage size for spdk_tgt to 2GiB #7606

Closed
derekbit opened this issue Jan 10, 2024 · 2 comments
Closed

[IMPROVEMENT] Increase the hugepage size for spdk_tgt to 2GiB #7606

derekbit opened this issue Jan 10, 2024 · 2 comments
Assignees
@derekbit @chriscchien
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function require/doc Require updating the longhorn.io documentation require/important-note Upgrade, Deprecation, Important notes
Milestone
v1.6.0

Comments

@derekbit
Copy link
Member

Is your improvement request related to a feature? Please describe (👍 if you like this request)

To address some feedback from uses and increase better UX, increase the hugepage size for spdk_tgt to 2GiB.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@derekbit derekbit added require/doc Require updating the longhorn.io documentation kind/improvement Request for improvement of existing function labels Jan 10, 2024
@derekbit derekbit added this to the v1.6.0 milestone Jan 10, 2024
@derekbit derekbit self-assigned this Jan 10, 2024
@derekbit derekbit added the area/v2-data-engine v2 data engine (SPDK) label Jan 10, 2024
@innobead innobead added the require/important-note Upgrade, Deprecation, Important notes label Jan 10, 2024
This was referenced Jan 10, 2024
Merged
Merged
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 10, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Check environment_check.sh and longhorn-spdk-setup.yaml
  2. Install LH by helm
  3. Check node hugepage value
    kubectl get node -o yaml and search huge. The value should be 2GiB
  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

#7607

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2443

  • Which areas/issues this PR might have potential impacts on?
    Area: v2 volume, prerequisites
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

longhorn/website#837

@chriscchien
Copy link
Contributor

Verified pass on longhorn master(longhorn d918ad)

Setup v2 engine environment by instructions and then install longhorn by both kubectl and helm, after longhorn ready, all nodes have hugepages-2Mi: 2Gi value in status.capacity and status.allocatable

status:
  addresses:
  - address: 172.31.47.74
    type: InternalIP
  - address: ip-172-31-47-74
    type: Hostname
  allocatable:
    cpu: "4"
    ephemeral-storage: "98672037811"
    hugepages-1Gi: "0"
    hugepages-2Mi: 2Gi
    memory: 14268920Ki
    pods: "110"
  capacity:
    cpu: "4"
    ephemeral-storage: 101430960Ki
    hugepages-1Gi: "0"
    hugepages-2Mi: 2Gi
    memory: 16366072Ki
    pods: "110"

> kubectl get node -o yaml | grep huge
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi
      hugepages-1Gi: "0"
      hugepages-2Mi: 2Gi

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@chriscchien chriscchien

Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function require/doc Require updating the longhorn.io documentation require/important-note Upgrade, Deprecation, Important notes
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.0
Development

No branches or pull requests
4 participants
@innobead @derekbit @longhorn-io-github-bot @chriscchien