Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Prevent from complains in spdk_tgt when deleting a v2 volume #7568

Closed
derekbit opened this issue Jan 7, 2024 · 4 comments
Closed

[IMPROVEMENT] Prevent from complains in spdk_tgt when deleting a v2 volume #7568

derekbit opened this issue Jan 7, 2024 · 4 comments
Assignees
@yangchiu @derekbit @roger-ryao
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function
Milestone
v1.6.0

Comments

@derekbit
Copy link
Member

derekbit commented Jan 7, 2024

Is your improvement request related to a feature? Please describe (👍 if you like this request)

spdk_tgt complains the improper sequence of deleting engines and replicas.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@derekbit derekbit added require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Jan 7, 2024
@derekbit derekbit added this to the v1.6.0 milestone Jan 7, 2024
@derekbit derekbit self-assigned this Jan 7, 2024
@github-actions github-actions bot mentioned this issue Jan 7, 2024
Closed
@derekbit derekbit mentioned this issue Jan 7, 2024
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 7, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create a v2 volume with 3 replicas by pod_with_pvc.yaml
  2. Delete the volume
  3. After applying the fix, longhorn-manager pods' logs should not emit nvme errors from spdk_tgt.

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2433

  • Which areas/issues this PR might have potential impacts on?
    Area: volume detachment
    Issues

@roger-ryao
Copy link

roger-ryao commented Jan 9, 2024 •
edited
Loading

Verified on master-head 20240109

The test steps

  1. [IMPROVEMENT] Prevent from complains in spdk_tgt when deleting a v2 volume #7568 (comment)

Result

  • require/doc : No documentation needed for this improvement
  • require/auto-e2e-test : Not applicable
  • require/backport : Should this improvement be backported to Longhorn 1.5.x?

cc @derekbit

@derekbit
Copy link
Member Author

derekbit commented Jan 9, 2024

require/backport

I think we don't need to backport it. WDYT? @innobead

require/doc

Internal improvement. doc is not needed.

require/auto-e2e-test

The update is making spdk_tgt stop complain. e2e-test is not needed as well.

@innobead innobead removed require/backport Require backport. Only used when the specific versions to backport have not been definied. require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation labels Jan 9, 2024
@innobead
Copy link
Member

innobead commented Jan 9, 2024

Those labels are added by default for improvement tickets. Remove them next time if there is no needed.

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangchiu yangchiu

@derekbit derekbit

@roger-ryao roger-ryao

Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.0
Development

No branches or pull requests
5 participants
@innobead @yangchiu @derekbit @longhorn-io-github-bot @roger-ryao