Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] v2 volume supports filesystem trim #7534

Closed
2 tasks done
derekbit opened this issue Jan 4, 2024 · 5 comments
Closed
2 tasks done

[FEATURE] v2 volume supports filesystem trim #7534

derekbit opened this issue Jan 4, 2024 · 5 comments
Assignees
@derekbit @chriscchien
Labels
area/spdk SPDK upstream/downstream area/v2-data-engine v2 data engine (SPDK) kind/feature Feature request, new feature priority/0 Must be implement or fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/important-note Upgrade, Deprecation, Important notes
Milestone
v1.7.0

Comments

@derekbit
Copy link
Member

derekbit commented Jan 4, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe (👍 if you like this request)

v2 volume supports filesystem trim

Describe the solution you'd like

The feature request includes the subtasks

Describe alternatives you've considered

Additional context
@derekbit derekbit added kind/feature Feature request, new feature require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal area/v2-data-engine v2 data engine (SPDK) labels Jan 4, 2024
@derekbit derekbit added this to the v1.7.0 milestone Jan 4, 2024
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Open
@derekbit derekbit added the priority/0 Must be implement or fixed in this release (managed by PO) label Jan 5, 2024
@innobead
Copy link
Member

@derekbit is this a duplicated one as you have worked on another issue related to unmap?

@innobead innobead added the area/spdk SPDK upstream/downstream label Feb 25, 2024
@derekbit
Copy link
Member Author

@derekbit is this a duplicated one as you have worked on another issue related to unmap?

There is a subtask #7925.

@derekbit derekbit mentioned this issue Feb 26, 2024
Closed
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Feb 26, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create a workload with a v2 volume
  2. Test trim operation. The behavior should be same as v1 volume.

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/spdk#28
longhorn/longhorn-manager#2648

  • Which areas/issues this PR might have potential impacts on?
    Area: v2 volume, spdk, trim, unmap
    Issues

@derekbit derekbit removed the require/lep Require adding/updating enhancement proposal label Feb 26, 2024
@derekbit derekbit mentioned this issue Feb 27, 2024
Closed
@derekbit derekbit mentioned this issue Apr 28, 2024
Merged
@chriscchien chriscchien self-assigned this May 29, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn master(longhorn-manager ad7420) with test steps

Filesystem trim operation worked properly on V2 volume.

@derekbit derekbit mentioned this issue Jul 25, 2024
Merged
@derekbit derekbit added the require/important-note Upgrade, Deprecation, Important notes label Jul 25, 2024
@derekbit
Copy link
Member Author

Updated in longhorn/website#951

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@chriscchien chriscchien

Labels
area/spdk SPDK upstream/downstream area/v2-data-engine v2 data engine (SPDK) kind/feature Feature request, new feature priority/0 Must be implement or fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/important-note Upgrade, Deprecation, Important notes
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.7.0
Development

No branches or pull requests
4 participants
@innobead @derekbit @longhorn-io-github-bot @chriscchien