Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] BackingImage should be compressed when downloading and use the name as filename instead of UUID #7295

Closed
ChanYiLin opened this issue Dec 8, 2023 · 2 comments
Closed

[IMPROVEMENT] BackingImage should be compressed when downloading and use the name as filename instead of UUID #7295

ChanYiLin opened this issue Dec 8, 2023 · 2 comments
Assignees
@ChanYiLin @chriscchien
Labels
area/backing-image Backing image related backport/1.4.5 backport/1.5.4 kind/improvement Request for improvement of existing function
Milestone
v1.6.0

Comments

@ChanYiLin
Copy link
Contributor

ChanYiLin commented Dec 8, 2023 •
edited by innobead
Loading

Is your improvement request related to a feature? Please describe (👍 if you like this request)

From this issue #7288
BackingImage should be compressed when downloading and use the name as filename instead of UUID

cc @innobead @m-ildefons
@ChanYiLin ChanYiLin added the area/backing-image Backing image related label Dec 8, 2023
@ChanYiLin ChanYiLin self-assigned this Dec 8, 2023
@ChanYiLin ChanYiLin added this to the v1.6.0 milestone Dec 8, 2023
@ChanYiLin ChanYiLin mentioned this issue Dec 15, 2023
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 15, 2023 •
edited by ChanYiLin
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

    • steps
      • create backingimage
      • download the backingimage
      • download file name is backing image name and it is compressed as gzip file
      • unzip the file and check the checksum is the same

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

@innobead innobead added the kind/improvement Request for improvement of existing function label Dec 18, 2023
@innobead innobead assigned m-ildefons and unassigned m-ildefons Dec 18, 2023
This was referenced Dec 20, 2023
Closed
Closed
@chriscchien chriscchien self-assigned this Dec 26, 2023
@chriscchien
Copy link
Contributor

Verified pass on longhorn master (backing-image-manager a8bf86) with test steps

  1. Downloaded backingimage now is in gzip format, the name of the download file is backingimage name, not UUID anymore.
  2. After unzip file, the result of command sha512sum was the same from UI as well as from command(kubectl describe backimgimage)
  3. Verified in raw and qcow2(download and export-from-volume)
  4. Upload the unzipped backingimage to Longhorn, create volume with that backingimage, data intact.

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChanYiLin ChanYiLin

@chriscchien chriscchien

Labels
area/backing-image Backing image related backport/1.4.5 backport/1.5.4 kind/improvement Request for improvement of existing function
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.6.0
Development

No branches or pull requests
5 participants
@innobead @ChanYiLin @m-ildefons @longhorn-io-github-bot @chriscchien