Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Collect v2 Data Engine related info for the usage metrics #6033

Closed
c3y1huang opened this issue Jun 1, 2023 · 3 comments
Closed
Assignees
Labels
area/monitoring System (cluster, node) or volume metrics, logs, stats area/v2-data-engine v2 data engine (SPDK) component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@c3y1huang
Copy link
Contributor

c3y1huang commented Jun 1, 2023

Is your improvement request related to a feature? Please describe (👍 if you like this request)

Enhance the collections to include SPDK implementation.

Describe the solution you'd like

  • Add node disk type (filesystem, block) collection
  • Add volume backend store driver (v1, v2)
  • Collect device type when disk type is block

Describe alternatives you've considered

None

Additional context

longhorn/longhorn-manager#1891 (comment)
longhorn/longhorn-manager#2346 (comment)

@c3y1huang c3y1huang added component/longhorn-manager Longhorn manager (control plane) area/monitoring System (cluster, node) or volume metrics, logs, stats kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) labels Jun 1, 2023
@innobead
Copy link
Member

innobead commented Jun 1, 2023

cc @derekbit @shuo-wu

@innobead innobead added this to the v1.6.0 milestone Jun 1, 2023
@innobead innobead added the priority/0 Must be implement or fixed in this release (managed by PO) label Jun 1, 2023
@c3y1huang c3y1huang added the require/manual-test-plan Require adding/updating manual test cases if they can't be automated label Dec 8, 2023
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 11, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML/chart change is at: feat(metrics): add schema for SPDK info collection to upgrade responder #7296

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at feat(telemetry): collect SPDK related info longhorn-manager#2346

  • Which areas/issues this PR might have potential impacts on?
    Area monitoring, spdk
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at doc(telemetry): collect SPDK node disk type website#807.

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at test(manual): upgrade responder should collect SPDK info longhorn-tests#1619

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@c3y1huang c3y1huang changed the title [IMPROVEMENT] Collect SPDK device type for the usage metrics [IMPROVEMENT] Collect SPDK related info for the usage metrics Dec 12, 2023
@innobead innobead changed the title [IMPROVEMENT] Collect SPDK related info for the usage metrics [IMPROVEMENT] Collect v2 Data Engine related info for the usage metrics Dec 18, 2023
@chriscchien chriscchien self-assigned this Dec 22, 2023
@chriscchien
Copy link
Contributor

Verified pass on longhorn master (longhorn-manager c46a54) with test steps

Deploy Longhorn and create 3 v1 volumes and 2 v2 volumes:

longhorn_disk_filesystem_Count

> kubectl exec -it ${influxdb_pod} -- influx -execute 'SELECT "longhorn_disk_filesystem_count" FROM "upgrade_request"' -database="${app_name}_upgrade_responder"
name: upgrade_request
time                longhorn_disk_filesystem_count
----                ------------------------------
1703234426043451144 1
1703234426882845418 1
1703234426998184569 1

longhorn_disk_block_count

> kubectl exec -it ${influxdb_pod} -- influx -execute 'SELECT "longhorn_disk_block_count" FROM "upgrade_request"' -database="${app_name}_upgrade_responder"
name: upgrade_request
time                longhorn_disk_block_count
----                -------------------------
1703234426043451144 1
1703234426998184569 1

longhorn_volume_backend_store_driver_v1_count

> kubectl exec -it ${influxdb_pod} -- influx -execute 'SELECT "longhorn_volume_backend_store_driver_v1_count" FROM "upgrade_request"' -database="${app_name}_upgrade_responder"
name: upgrade_request
time                longhorn_volume_backend_store_driver_v1_count
----                ---------------------------------------------
1703234426043451144 3

longhorn_volume_backend_store_driver_v2_count

> kubectl exec -it ${influxdb_pod} -- influx -execute 'SELECT "longhorn_volume_backend_store_driver_v2_count" FROM "upgrade_request"' -database="${app_name}_upgrade_responder"
name: upgrade_request
time                longhorn_volume_backend_store_driver_v2_count
----                ---------------------------------------------
1703234426043451144 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring System (cluster, node) or volume metrics, logs, stats area/v2-data-engine v2 data engine (SPDK) component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Status: Closed
Development

No branches or pull requests

4 participants