Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT][UI] Recurring jobs create new snapshots while being not able to clean up old one #5610

Closed
innobead opened this issue Mar 20, 2023 · 8 comments
Assignees
Labels
area/recurring-job Longhorn recurring job related area/ui UI related like UI or CLI backport/1.3.3 backport/1.4.2 kind/improvement Request for improvement of existing function
Milestone

Comments

@innobead
Copy link
Member

Is your improvement request related to a feature? Please describe (👍 if you like this request)

Need to support UI for two new recurring jobs. #4898

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Mar 22, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. In Recurring Job page of Longhorn UI
  2. Click Create Recurring Job button
  3. In drop-down menu of Task, you can see and select types Backup Force Create and Snapshot Force Create.
  4. Choose one task type of Backup Force Create and Snapshot Force Create and click OK
  5. The recurring job will be created successfully.
  6. Repeat steps 1 to 5 in Volume Details page of Longhorn UI.
  7. The recurring job will be created successfully as well.

@innobead
Copy link
Member Author

@mantissahz Please provide the test steps.

@mantissahz
Copy link
Contributor

Updated the test steps in #5610 (comment)

@khushboo-rancher
Copy link
Contributor

Just a suggestion instead of Backup Force Create and Snapshot Force Create in the task, can we have a check box for Force create when user selects Backup or Snapshot?

cc: @innobead

@innobead
Copy link
Member Author

Just a suggestion instead of Backup Force Create and Snapshot Force Create in the task, can we have a check box for Force create when user selects Backup or Snapshot?

cc: @innobead

@smallteeths Can we help with this? Probably need a tip for the checkbox. @mantissahz Could you help follow up with @smallteeths ? Thanks.

@smallteeths
Copy link
Contributor

Just a suggestion instead of Backup Force Create and Snapshot Force Create in the task, can we have a check box for Force create when user selects Backup or Snapshot?
cc: @innobead

@smallteeths Can we help with this? Probably need a tip for the checkbox. @mantissahz Could you help follow up with @smallteeths ? Thanks.

Sure, I'll make the modification. When the user selects "backup" and checks the "Force create" option, the type of recurring job will be "Force create backup". The same logic applies to snapshots as well.

@roger-ryao
Copy link

Verified on master-head 20230414

  • longhorn master-head (ccf9f3a)
  • longhorn-manager master-head (092eca2)
  • longhorn-ui master-head (3ddbe5d)

The test steps

  1. In the Longhorn UI, go to the Recurring Job page.
  2. Click on the Create Recurring Job button.
  3. From the Task dropdown menu, select either Backup or Snapshot.
  4. Check the Force create option.
  5. Verify that the recurring job task has been updated to Force create backup or Force create snapshot accordingly.
  6. Click OK to create the recurring job.
  7. Repeat steps 1-6 on the Volume Details page in the Longhorn UI.

Result Passed

@khushboo-rancher
Copy link
Contributor

@roger-ryao Could you please attach a screenshot here. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/recurring-job Longhorn recurring job related area/ui UI related like UI or CLI backport/1.3.3 backport/1.4.2 kind/improvement Request for improvement of existing function
Projects
Status: Closed
Development

No branches or pull requests

6 participants