Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Error message not consistent between create/update recurring job when retain number greater than 50 #5434

Closed
chriscchien opened this issue Feb 22, 2023 · 2 comments
Closed

[BUG] Error message not consistent between create/update recurring job when retain number greater than 50 #5434

chriscchien opened this issue Feb 22, 2023 · 2 comments
Assignees
@c3y1huang @chriscchien
Labels
backport/1.3.3 backport/1.4.1 component/longhorn-manager Longhorn manager (control plane) kind/bug kind/regression Regression which has worked before severity/3 Function working but has a major issue w/ workaround
Milestone
v1.5.0

Comments

@chriscchien
Copy link
Contributor

Describe the bug (🐛 if you encounter this issue)

Error messages between create/update recurring job with retain number > 50 were not consistent .

Create recurring job with retain number > 50:

retain value should be less than or equal to 50

Update recurring job with retain number > 50:

retain in body should be less than or equal to 50

To Reproduce

Steps to reproduce the behavior:

  1. Create recurring job with retain number 51 and record the error message
  2. Create legal recurring job then update the retain number to 51 and record the error message
  3. Compare those 2 error messages and they were different

Expected behavior

Have the same error message.

Log or Support bundle

N/A

Environment

  • Longhorn version: Longhorn manager master 47d3b1

Additional context

Test case test_recurring_jobs_maximum_retain was effected. Need to update test case after this ticket resolved
@chriscchien chriscchien added kind/bug kind/regression Regression which has worked before severity/3 Function working but has a major issue w/ workaround labels Feb 22, 2023
@chriscchien chriscchien mentioned this issue Feb 22, 2023
Closed
2 tasks
@c3y1huang c3y1huang self-assigned this Feb 22, 2023
@c3y1huang c3y1huang added this to the v1.5.0 milestone Feb 22, 2023
This was referenced Feb 22, 2023
Closed
Closed
@c3y1huang c3y1huang mentioned this issue Feb 22, 2023
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Feb 22, 2023 •
edited by c3y1huang
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at:

  • Which areas/issues this PR might have potential impacts on?
    Area manager
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@chriscchien chriscchien mentioned this issue Feb 23, 2023
Merged
@chriscchien
Copy link
Contributor Author

Verified in Longhorn manager master 606392
Result Pass

In longhorn-manager master, create/update recurring job with retain number > 50 now have the same error message
admission webhook "validator.longhorn.io" denied the request: retain value should be less than or equal to 50

@derekbit derekbit moved this to Closed in Longhorn Sprint Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c3y1huang c3y1huang

@chriscchien chriscchien

Labels
backport/1.3.3 backport/1.4.1 component/longhorn-manager Longhorn manager (control plane) kind/bug kind/regression Regression which has worked before severity/3 Function working but has a major issue w/ workaround
Projects
Longhorn Sprint
Status: Closed
Milestone
v1.5.0
Development

No branches or pull requests
3 participants
@c3y1huang @longhorn-io-github-bot @chriscchien