-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Duplicate channel close error in the backing image manage related components #4865
Comments
Hi @innobead |
Pre Ready-For-Testing Checklist
|
Verified on master-head 20221208 The test steps Scenario 1 Scenario 2
Result
Scenario 2 |
@roger-ryao @shuo-wu : what is the largest file ever tested? users are reporting with a 75GB local file to upload, it failed. could it be related to POD resource restriction or disk space pressure ? thanks. |
@w13915984028 What longhorn version is the user using? This fix is only going to 1.4.0 and 1.3.3. |
I see. If that's streaming, don't think that's a problem. Let's see the update from @roger-ryao / @shuo-wu . |
Hi @w13915984028 |
We suspect the large image file (e.g. 50Gb ~ 100Gb) may cause pressue to the PODs in the uploading path, when possible, please test with such big image files. And also add them into auto test. LH will have a specification, saying which size of image can be handled smoothly. thanks. |
@w13915984028 Is the large file uploading failure caused by this kind of issue? |
@shuo-wu #4902 touchs more components, the vm-importer is an upper layer controller, which utilize the uploading functionality. |
@w13915984028 Let's create another issue to track large file uploading instead to clarify this further. |
OK, lets discuss further in #5395, thanks. |
Describe the bug (🐛 if you encounter this issue)
There is duplicate channel closing that will lead to the longhorn manager panic.
For example, when the backing image data source is unreachable for a while and the monitor failed to retry connecting it, the stop channel will be closed both in the sync function and in a separate stop monitoring function.
To Reproduce
Steps to reproduce the behavior:
panic: close of closed channel
Expected behavior
The backing image downloading will be marked as failed without any panic
Log or Support bundle
Environment
Additional context
Thanks for @ibrokethecloud's reporting!
The text was updated successfully, but these errors were encountered: