Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ssl on server mode to netty #122

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Port ssl on server mode to netty #122

merged 3 commits into from
Oct 4, 2018

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Aug 31, 2018 •
edited
Loading

replaces #106

  • includes Port server-mode SSL to Netty. #106 port of ssl server path to netty
  • adds a ruby class that creates SslContext if PKCS#1 keys are used
  • refactors travis testing setup to use tarballs instead of compiling logstash

If necessary, the travis refactor can be removed as it's contained in a single commit (5789690)

The initial commit from #106 was preserved.

fixes #104

@jsvd jsvd force-pushed the port_ssl_to_netty branch from 45ad52c to b4e599f Compare August 31, 2018 11:27
@jsvd jsvd force-pushed the port_ssl_to_netty branch 2 times, most recently from 6dad797 to a15a6f0 Compare September 4, 2018 14:22
@jsvd jsvd force-pushed the port_ssl_to_netty branch 2 times, most recently from e692a05 to 77fa893 Compare September 4, 2018 17:47
@jsvd jsvd force-pushed the port_ssl_to_netty branch from 77fa893 to 5789690 Compare September 5, 2018 12:27
@jsvd jsvd changed the title Port ssl to netty Port ssl on server mode to netty Sep 5, 2018
@jsvd jsvd requested a review from danhermann September 5, 2018 13:00
@jsvd jsvd mentioned this pull request Sep 5, 2018
Closed
danhermann
danhermann approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM -- nice catch on the PKCS#1 keys!

@jsvd jsvd merged commit 0a1e70e into logstash-plugins:master Oct 4, 2018
@jsvd jsvd deleted the port_ssl_to_netty branch October 4, 2018 14:18
@jsvd
Copy link
Member Author

jsvd commented Oct 4, 2018

Many thanks for the review @danhermann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhermann danhermann danhermann approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish migration to Netty (TLS still uses Ruby Sockets)
2 participants
@jsvd @danhermann