issue #200: update leader timeouts after disk write #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // reset election timer to avoid punishing the leader for our own | ||
| // long writes | ||
| stepDown(request.term()); |
There was a problem hiding this comment.
No need to call stepDown again here.
| // This request is a sign of life from the current leader. Update | ||
| // our term and convert to follower if necessary; reset the | ||
| // election timer. set it here in case we exit early, we will set | ||
| // it again after the write |
There was a problem hiding this comment.
"exit early" -> "exit this function early"
"write" -> "disk write"
|
Cool. stepDown is there (above) to ensure this server is a follower in the same term (it might not have participated in the election). |
|
Probably also worth updating copyright header and release notes. |
|
ok, re-pushed with those changes. is this issue able to repro'd somewhere in the logcabin unit tests? |
| @@ -15,6 +15,10 @@ See [RELEASE-PROCESS.md](RELEASE-PROCESS.md). | |||
| Version 1.2.0-alpha.0 (In Development) | |||
| ====================================== | |||
|
|
|||
| Bug fixes (low severity): | |||
|
|
|||
| - #200: reset leader election timeout in follower after disk io completes | |||
There was a problem hiding this comment.
That's an improvement, not a bug fix :)
|
Let me think about the unit testing question. At least we should be able to find a clean way to check that the code is doing what we expect (whitebox). |
in cases where disk writes can take longer than the leader election, a follower can call for an election when one is not necessary. this change resets the election related timers after all disk writes.
|
pushed another. |
ongardie
added a commit
that referenced
this pull request
Feb 11, 2016
issue #200: update leader timeouts after disk write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in cases where disk writes can take longer than the leader election,
a follower can call for an election when one is not necessary. this
change resets the election related timers after all disk writes.
I don't fully understand what stepDown is doing or if we should call it again, but it does seem related to the other calls so I duplicated it, so I left in. In testing, this change is helping prevent the stated problem, which makes sense. I'll make whatever changes are requested.