-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sigmoidal contrast calculation #3328
Fix sigmoidal contrast calculation #3328
Conversation
3f5120e
to
b630b12
Compare
Hey @JanssenBrm I tried to facilitate a bit the ECA process however it turned out you can't do it now anymore. So could you sign ECA? |
Hi @pomadchin , My apologies for the late response. Meanwhile, I have signed the ECA on the Eclipse Foundation website. |
@JanssenBrm could you share an email you signed the ECA with? I see your Eclipse profile but I don't know the email address and this commit is signed with a different one :) Btw, feel free to create a new PR signed and commited with an appropriate email. |
@pomadchin - That's strange, it is signed with brm.janssen@gmail.com, which is the same email I use within GitHub. |
@pomadchin It seemed that I was using an incorrect email indeed. I have updated this locally and signed the last commit with the appropriate username and email. Should I create a new PR for this? |
b630b12
to
b73b38a
Compare
Signed-off-by: JanssenBrm <brm.janssen@gmail.com>
b73b38a
to
55b6cf9
Compare
@JanssenBrm Thanks! Nope that's all good now! It used your vito email. Yep, I think it was your Thanks for a nice catch and sorry that the process to get some code merged is harder that it should be :D |
@pomadchin Thanks for the merge! It was my first PR here so it was just a bit getting used to but the process itself is very straightforward :) |
A backport of #3327 with an updated CHANGELOG and added comment strings
Checklist
docs
guides update, if necessaryCloses #3326