Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sigmoidal contrast calculation #3328

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Dec 23, 2020

A backport of #3327 with an updated CHANGELOG and added comment strings

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • docs guides update, if necessary

Closes #3326

@pomadchin pomadchin changed the title Updated geotrellis sigmoidal contrast calculation Fix sigmoidal contrast calculation Dec 23, 2020
@pomadchin pomadchin force-pushed the fix/sigmoid-correction branch from 3f5120e to b630b12 Compare December 23, 2020 13:37
@pomadchin
Copy link
Member Author

Hey @JanssenBrm I tried to facilitate a bit the ECA process however it turned out you can't do it now anymore.

So could you sign ECA?

@JanssenBrm
Copy link
Contributor

Hi @pomadchin ,

My apologies for the late response. Meanwhile, I have signed the ECA on the Eclipse Foundation website.

@pomadchin
Copy link
Member Author

pomadchin commented Dec 29, 2020

@JanssenBrm could you share an email you signed the ECA with? I see your Eclipse profile but I don't know the email address and this commit is signed with a different one :)

Btw, feel free to create a new PR signed and commited with an appropriate email.

@JanssenBrm
Copy link
Contributor

@pomadchin - That's strange, it is signed with brm.janssen@gmail.com, which is the same email I use within GitHub.

@JanssenBrm
Copy link
Contributor

@pomadchin It seemed that I was using an incorrect email indeed. I have updated this locally and signed the last commit with the appropriate username and email. Should I create a new PR for this?

@pomadchin pomadchin force-pushed the fix/sigmoid-correction branch from b630b12 to b73b38a Compare December 29, 2020 13:50
Signed-off-by: JanssenBrm <brm.janssen@gmail.com>
@pomadchin pomadchin force-pushed the fix/sigmoid-correction branch from b73b38a to 55b6cf9 Compare December 29, 2020 13:51
@pomadchin
Copy link
Member Author

pomadchin commented Dec 29, 2020

@JanssenBrm Thanks! Nope that's all good now! It used your vito email. Yep, I think it was your git config --global user.email setting. Merging this PR.

Thanks for a nice catch and sorry that the process to get some code merged is harder that it should be :D

@pomadchin pomadchin merged commit 73976bc into locationtech:master Dec 29, 2020
@pomadchin pomadchin deleted the fix/sigmoid-correction branch December 29, 2020 13:53
@JanssenBrm
Copy link
Contributor

@pomadchin Thanks for the merge! It was my first PR here so it was just a bit getting used to but the process itself is very straightforward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SigmoidalContrast - Imcomplete formula
2 participants