Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace LayerUpdater usage with LayerWriter.update #2663

Merged
merged 8 commits into from
May 9, 2018
Merged

Replace LayerUpdater usage with LayerWriter.update #2663

merged 8 commits into from
May 9, 2018

Conversation

echeipesh
Copy link
Contributor

@echeipesh echeipesh commented May 8, 2018 •
edited
Loading

Overview

  • Remove LayerUpdater trait hierarchy
  • Update tests to use LayerWriter.update
  • Centralize logic for record merging among LayerWriter implementations

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

@echeipesh echeipesh mentioned this pull request May 8, 2018
Closed
@echeipesh echeipesh requested a review from moradology May 8, 2018 22:14
@echeipesh echeipesh force-pushed the fix/layer-updater-order branch from 5fa1392 to 243c1c1 Compare May 9, 2018 14:28
@echeipesh echeipesh merged commit f5601fb into locationtech:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moradology moradology Awaiting requested review from moradology

Assignees
No one assigned
Labels
api change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@echeipesh