Fix 2166 #2171
Merged
Fix 2166 #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user defined CellTypes. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
…nitions and string representations, particularly for JSON serialization. Addresses issues outlined in locationtech#2166, where specific NoData values that are negative, or ones for unsigned CellTypes that overflow JVM native encodings (e.g. uint8ud255). As a part of the refactoring, expanded the tests around edge cases associated with numeric bounds. The only public API change is the addition of the method `UserDefinedNoData.widenedNoData`. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Found by @mteldridge Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
… actual TIFF file. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
lossyrob
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of code responsible for translating to/from CellType definitions
and string representations, particularly for JSON serialization. Addresses issues
outlined in #2166, where specific NoData values that are negative, or ones
for unsigned CellTypes that overflow JVM native encodings (e.g. uint8ud255).
As a part of the refactoring, expanded the tests around edge cases associated
with numeric bounds. The only public API change is the addition of the
method
UserDefinedNoData.widenedNoData.