-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interpretAs and withNoData methods to Tile #1702
Add interpretAs and withNoData methods to Tile #1702
Conversation
Allows for more flexibility when working around NoData values
It was dropping NoDataHandling portions of CellType
Is this WIP until the RFC gets worked out? |
I'd be happy to bundle them together, but they don't have to be. This PR can be merged as is and addresses the issue that spawned it. |
b9c3a05
to
6f3a2ab
Compare
@lossyrob @moradology Ready for review again after One final through is that what is currently
|
@echeipesh I think |
I also think |
I prefer
|
Semantic ambiguity could be addressed in docstrings. |
+1 |
I like the word
|
Thank you everybody for chiming in on the naming! |
Fixes: #1674
Allows for more flexibility when working around NoData values.
Additionally this expands the capacity of the
ConstantTile
to represent constant tiles other than tiles withConstantNoDataHandling
to satisfy the conversions implied by the new API.TODO:
Tile.withNoData
noDataValue
constructor overload