Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Setuptools to exclude tests during packaging #40

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

dv297
Copy link
Contributor

@dv297 dv297 commented Dec 8, 2023

Motivation

I installed tflocal to my project and noticed that my absolute import within my tests directory was getting overriden by a tests directory found within my .venv/libs/python/site-packages directory. This pull request makes a minor update to the setup.cfg to exclude this project's unit tests from the distributable.

Evidence

Before, the content of the .tar.gz dist with a tests directory
image

After, the content of the .tar.gz dist without a tests directory
image

@alexrashed alexrashed requested a review from lakkeger December 11, 2023 08:21
Copy link
Contributor

@lakkeger lakkeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dv297,
You are a 100% right, thanks for pointing it out. I approved your changes 🎉

@lakkeger lakkeger merged commit d1f9d75 into localstack:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants